-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perf event writes metric #4334
Perf event writes metric #4334
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
b3a3181
to
fadf5a8
Compare
I'm working on a stress tool on top of this branch. Gonna let you know soon. |
I actually prefer having this in a debug build precisely so that we don't include these overheads in regular user runtimes. |
fadf5a8
to
5d46a84
Compare
fac164c
to
7633d97
Compare
a7412c1
to
d58139d
Compare
d58139d
to
f1e3b2b
Compare
f1e3b2b
to
cbe8510
Compare
cbe8510
to
c033971
Compare
@NDStrahilevitz @yanivagman I would appreciate your +1. |
c033971
to
9ba2407
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see one nit comment
I'll add a new commit to this to expose the new metrics via grpc. Gonna ping you soon. |
9ba2407
to
fa704db
Compare
fa704db
to
c8edcca
Compare
Enabled only when built with METRICS=1. BPFPerfEventSubmitAttemptsCount and BPFPerfEventSubmitFailuresCount count the number of events processed by the eBPF programs and written to or attempted to be written to the perf buffer. It is incremented right after the attempt of writing the event to the perf buffer, making it possible to measure if the that event was successfully written to the perf buffer or not. This metric can be used to monitor the performance of individual eBPF events and to detect potential bottlenecks.
c8edcca
to
bae1532
Compare
/fast-forward |
1. Explain what the PR does
bae1532 chore(performance): update tracee dashboard
5a5c2e7 chore: add perfbuf metric per event (METRICS=1)
5fe36d1 chore(go.mod): bump api to latest 1f796cb
5a5c2e7 chore: add perfbuf metric per event (METRICS=1)
2. Explain how to test it
METRICS=1 make tracee
sudo ./dist/tracee -e socket_dup,execve --metrics --pyroscope --pprof
make -f builder/Makefile.performance dashboard-start
3. Other comments