Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arg zero parse types and core typo #4357

Merged
merged 2 commits into from
Oct 20, 2024

Conversation

geyslan
Copy link
Member

@geyslan geyslan commented Oct 18, 2024

1. Explain what the PR does

7eafda0 fix(core): ctx_id types of io_ events typo**

io_destroy, io_getevents, io_submit and io_cancel were using an
inexistent type for ctx_id.

The same for io_setup's ctx_idp parameter.

2a3f0dd fix(parse): correct types sizes

This considers the size of the types based on vmlinux.h.

2. Explain how to test it

3. Other comments

This considers the size of the types based on vmlinux.h.
@geyslan geyslan added this to the v0.23.0 milestone Oct 18, 2024
@geyslan geyslan self-assigned this Oct 18, 2024
io_destroy, io_getevents, io_submit and io_cancel were using an
inexistent type for ctx_id.

The same for io_setup's ctx_idp parameter.
@geyslan geyslan force-pushed the arg-zero-parse-types branch from 36dffca to 7eafda0 Compare October 18, 2024 13:17
@geyslan geyslan removed this from the v0.23.0 milestone Oct 18, 2024
Copy link
Collaborator

@NDStrahilevitz NDStrahilevitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will require some fixes in my other PR I guess...

@geyslan
Copy link
Member Author

geyslan commented Oct 20, 2024

/fast-forward

@github-actions github-actions bot merged commit 7eafda0 into aquasecurity:main Oct 20, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants