-
Notifications
You must be signed in to change notification settings - Fork 18
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: ecr arn image ref support (#243)
Signed-off-by: chenk <[email protected]>
- Loading branch information
1 parent
dcdfdc5
commit 130fa1a
Showing
6 changed files
with
58 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "strings" | ||
|
|
||
| "github.com/aws/aws-sdk-go/aws/arn" | ||
| containerimage "github.com/google/go-containerregistry/pkg/name" | ||
| ) | ||
|
|
||
| func ParseReference(ref string) (containerimage.Reference, error) { | ||
| if strings.HasPrefix(ref, "arn:aws:ecr") { | ||
| parsed, err := arn.Parse(ref) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| ref = parsed.Resource | ||
| } | ||
| return containerimage.ParseReference(ref) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| package utils | ||
|
|
||
| import ( | ||
| "github.com/stretchr/testify/assert" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestParseRef(t *testing.T) { | ||
| imageRef, err := ParseReference("arn:aws:ecr:us-west-2:foo:repository/bar:latest") | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "repository/bar:latest", imageRef.String()) | ||
| } |