Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dart): add graph support #5374
feat(dart): add graph support #5374
Changes from 4 commits
aaa62e8
3863a5e
127f34b
c30a8d4
f5bbf4b
ffe7308
3abdc47
6543732
8a63355
1f58071
9c258ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use fsutils.WalkDir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is same case as with
go.mod
licenses -trivy/pkg/fanal/analyzer/language/golang/mod/mod.go
Line 265 in 6040d9f
Some example:
User uses default cache path (
~/.pub_cache
).But he scans project dir (e.g.
~/project1
).In this case we don't add
pubspec.yaml
files from~/.pub_cache
in FS for PostAnalyze.=> we can't read these files from
input.FS
.Correct me, if i missed something.
Perhaps we can use
os.DirFS("/")
(fsutils.WalkDir(os.DirFS("/"), ".", required, func(path string, d fs.DirEntry, r io.Reader) error
). But i am not sure that it make sense.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't
os.DirFS(dir)
work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After my suggestion about
os.DirFS
I didn't think of an obvious solution 😄 .Thank you!
I used
fsutils.WalkDir
in 3abdc47