Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(misconf): Reorganize misconfiguration scan pages #8206

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

docs(misconf): Reorganize misconfiguration scan pages #8206

wants to merge 3 commits into from

Conversation

simar7
Copy link
Member

@simar7 simar7 commented Jan 7, 2025 •
edited
Loading

Description

This PR updates the structure of the misconfiguration scanning docs. Also adds more info on schemas.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@itaysk
Copy link
Contributor

itaysk commented Jan 8, 2025

@simar7 is this intentionally Draft or should we review it?

@simar7 simar7 marked this pull request as ready for review January 8, 2025 18:45
nikpivkin
nikpivkin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one small comment

@knqyf263 knqyf263 requested a review from itaysk January 10, 2025 16:32
@itaysk
Copy link
Contributor

itaysk commented Jan 13, 2025

yes I want to review it but I'll get to it only later this week

@simar7 simar7 force-pushed the update-schema-docs branch from 56345fd to 140fd10 Compare January 16, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

@itaysk itaysk Awaiting requested review from itaysk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simar7 @itaysk @nikpivkin