Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for registry mirrors #8244
base: main
Are you sure you want to change the base?
feat: add support for registry mirrors #8244
Changes from all commits
b9d46d7
f798d68
04851e1
8c4f6c1
696be1f
392c920
678ba5c
c3682e0
ccbf7c7
f9b6d01
3d6e223
f097a43
8d269d2
ad56617
d7a1b7d
d082591
539e9f4
f3247f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, this page shows the default values. I'm wondering if it confuses users. Since the document describes an example, isn't it enough?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not adding flags support, so we need to include something in the config file docs.
But honestly, I added this example because I could come up with good lines for an empty
map[string][]string
This is a yaml file, and the
go
(map[string][]string
) syntax can be confusing to users.I can use
<..>
in the example. eg:let me know if you have another idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This document well describes how the configuration should look.
https://github.com/aquasecurity/trivy/blob/f3247f157a54cc050d66db7627164326b0dae607/docs/docs/configuration/others.md#mirror-registries
IMHO,
config-file.md
can be simplymirros:
because it's the default value.But your approach also looks good.
In that case, we may want to add a new field for examples and generate
config-file.md
from them rather than defining specific examples in magefilesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm impressed it works!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smart 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of nesting it, I prefer adding another method, like
tryRef
,tryImage
or something like that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in ad56617