Merge pull request #14 from aquasecurity/owenr-dont-use-terminal-for-…

…command

Switch to not use the terminal

.gitignore

@@ -3,4 +3,5 @@ dist
 node_modules
 .vscode-test/
 *.vsix
-*.js
+*.js
+package-lock.json

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to the "tfsec" extension will be documented in this file.
 
+### 1.4.0
+- Use output channel instead of terminal for better cross platform command support
+- Remove explicit run command and use refresh to update the list with a fresh run
+- Add ignore all severity
+- Fix the refresh after ignores have been completed
+- Add more information to the update output  
+
 ### 1.3.1
 - Update the repository link
 

README.md

@@ -27,6 +27,13 @@ Ignore codes will be automatically resolved and the description of the error wil
 
 ## Release Notes
 
+### 1.4.0
+- Use output channel instead of terminal for better cross platform command support
+- Remove explicit run command and use refresh to update the list with a fresh run
+- Add ignore all severity
+- Fix the refresh after ignores have been completed
+- Add more information to the update output 
+
 ### 1.3.1
 - Update the repository link
 

package.json

@@ -3,7 +3,7 @@
   "displayName": "tfsec",
   "publisher": "tfsec",
   "description": "tfsec integration for Visual Studio Code",
-  "version": "1.3.1",
+  "version": "1.4.0",
   "engines": {
     "vscode": "^1.54.0"
   },
@@ -67,17 +67,13 @@
         "command": "tfsec.run",
         "title": "tfsec: Run tfsec against workspace",
         "icon": {
-          "light": "resources/light/run.svg",
-          "dark": "resources/dark/run.svg"
+          "light": "resources/light/refresh.svg",
+          "dark": "resources/dark/refresh.svg"
         }
       },
       {
         "command": "tfsec.refresh",
-        "title": "tfsec: Refresh the issue list",
-        "icon": {
-          "light": "resources/light/refresh.svg",
-          "dark": "resources/dark/refresh.svg"
-        }
+        "title": "tfsec: Refresh the issue list"
       },
       {
         "command": "tfsec.updatebinary",
@@ -95,6 +91,10 @@
         "command": "tfsec.ignoreAll",
         "title": "Ignore all instances"
       },
+      {
+        "command": "tfsec.ignoreSeverity",
+        "title": "Ignore all instances of severity"
+      },
       {
         "command": "tfsec.version",
         "title": "tfsec: Get the current version of tfsec"
@@ -149,15 +149,10 @@
           "when": "view == tfsec.issueview",
           "group": "navigation@1"
         },
-        {
-          "command": "tfsec.refresh",
-          "when": "view == tfsec.issueview",
-          "group": "navigation@2"
-        },
         {
           "command": "tfsec.updatebinary",
           "when": "view == tfsec.issueview",
-          "group": "navigation@3"
+          "group": "navigation@2"
         }
       ],
       "view/item/context": [
@@ -168,6 +163,10 @@
         {
           "command": "tfsec.ignoreAll",
           "when": "view == tfsec.issueview && viewItem == TFSEC_CODE"
+        },
+        {
+          "command": "tfsec.ignoreSeverity",
+          "when": "view == tfsec.issueview && viewItem == TFSEC_SEVERITY"
         }
       ]
     }
@@ -189,7 +188,7 @@
     "eslint": "^7.27.0",
     "glob": "^7.1.7",
     "mocha": "^8.4.0",
-    "typescript": "^4.2.4",
+    "typescript": "^4.5.4",
     "vscode-test": "^1.5.0"
   },
   "repository": {

src/explorer/issues_treeview.ts

@@ -26,21 +26,13 @@ export class TfsecIssueProvider implements vscode.TreeDataProvider<TfsecTreeItem
 			if (!fs.existsSync(this.resultsStoragePath)) {
 				fs.closeSync(fs.openSync(this.resultsStoragePath, 'w'));
 			}
-			// create the file watcher to refresh the tree when changes are made
-			fs.watch(this.resultsStoragePath, (eventType) => {
-				if (eventType !== "change") {
-					return;
-				}
-				vscode.window.showInformationMessage("tfsec run complete, results file updated");
-				// short wait for the file to be written before refreshing the tree
-				setTimeout(() => { vscode.commands.executeCommand("tfsec.refresh"); }, 250);
-			});
 		}
 	}
 
 	refresh(): void {
 		this.taintResults = true;
 		this._onDidChangeTreeData.fire();
+		vscode.window.showInformationMessage("tfsec results updated");
 	}
 
 	// when there is a tfsec output file, load the results