Hide OneOfSchema Attributes

[mfleader]

Changes introduced with this PR

All attributes on the *Schema classes, like OneOfStringSchema or OneOfIntSchema, in schema.py must be public because the schema builder portion of schema.py uses metadata analysis of that class's attributes to determine if an instance of the Arcaflow type has been written as specified by the Arcaflow type system (implemented by the *Schema classes and a few other parts of this code base). As a language feature of Python, classes do not have private/hidden attributes. If a private attribute must exist on a *Schema class, then one solution is to encapsulate the required behavior or state on a part of the class that is not used as a part of the metadata analysis. In this pull request I have encapsulated the state we would like to be hidden within method calls on the relevant classes.

Testing for this behavior is not simple, and will have to be introduced in a follow-up pull request.

---

By contributing to this repository, I agree to the contribution guidelines.

[webbnh]

I like Dave's suggestion (assuming it addresses the problem).

[jaredoconnell]

Looks good. I haven't tested it with a plugin.

[mfleader]

For comparison, attached are the manually generated files of the Stress-NG plugin schema using the sdk's main branch, and this pull request's branch, oneof-attrs-privatize.

To reproduce:

❯ mkdir testdir
❯ cd testdir
❯ git clone https://github.com/arcalot/arcaflow-plugin-sdk-python.git
❯ git clone https://github.com/arcalot/arcaflow-plugin-stressng.git
❯ cd arcaflow-plugin-sdk-python/src
❯ cp -r ../../arcaflow-plugin-stressng/arcaflow_plugin_stressng .
❯ python arcaflow_plugin_stressng/stressng_plugin.py --schema > stressng_schema-main.txt
❯ git switch oneof-attrs-privatize
❯ python arcaflow_plugin_stressng/stressng_plugin.py --schema > stressng_schema-oneof-attrs-privatize.txt
❯ diff stressng_schema-main.txt stressng_schema-oneof-attrs-privatize.txt
760,761d759
<                   discriminator_type: string
<                   oneof_type: _discriminated_string_
2367,2368d2364
<                       discriminator_type: string
<                       oneof_type: _discriminated_string_

GitHub doesn't want me to upload a yaml file, so they are txt files.
stressng_schema-main.txt
stressng_schema-oneof-attrs-privatize.txt

[dbutenhof]

Oh, cool. 😁