-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AVR Compatibility #463
Open
zfields
wants to merge
1
commit into
arduino-libraries:master
Choose a base branch
from
zfields:zak-avr-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #463 +/- ##
==========================================
- Coverage 95.26% 95.11% -0.15%
==========================================
Files 32 31 -1
Lines 1478 1434 -44
==========================================
- Hits 1408 1364 -44
Misses 70 70 ☔ View full report in Codecov by Sentry. |
Memory usage change @ b304eb3
Click for full report table
Click for full report CSV
|
per1234
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
labels
May 17, 2024
Memory usage change @ d5966e6
Click for full report table
Click for full report CSV
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the implementation to be compatible with
avr-gcc
, which can then be supported by the Notecard.The core change is to templatize the implementation on
CloudInt
.This allows the library to accept all sizes and signed-ness of integers without requiring multiple implementations (e.g.
CloudInt
,CloudUnsignedInt
, etc...). Several cascading changes are then required to accommodate this main change.Other changes include pulling in ArduinoSTL for
std::list
support, and migrating lambda expressions to static functions.