-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using mbed pin names and external defines #27
Conversation
Memory usage change @ 8216529
Click for full report table
Click for full report CSV
|
This should fix #9 and arduino-libraries/Arduino_MachineControl#85, isn't it? |
Perhaps "mitigate", but no I wouldn't say "fix". The reason is that it is not really feasible for the average user to set a global definition for the This is something boards platform authors can do with ease, but it is likely only a few very specific 3rd party platforms might do that, especially considering it is undocumented. Advanced users can do it, but even for them it will not be convenient. |
@facchinm LGTM. Please, merge and release a new version! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.