Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove LTO settings in build flags... #22302

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

Jason2866
Copy link
Collaborator

@Jason2866 Jason2866 commented Oct 16, 2024

Description:

since LTO is now standard in Tasmota Arduino framework. No changes in resulting firmwares when compiling Tasmota (with Arduino framework, which is default).
By removing this setting (IDF code is not LTO ready) and some small changes in IDF (Tasmota is using an IDF fork) it is possible to build Tasmota as an Arduino component of IDF. This compile option will result in general in bigger Tasmota firmware size (since no LTO possible)
It is an way to change all available settings from IDF.

To build Tasmota as an Arduino as a component of IDF project add in platformio.ini
to the entry framework = arduino the entry espidf resulting in framework = arduino, espidf
This change will affect ALL [env]. Since there is no espidf for esp8266 [env] for, all will fail to compile. To build Tasmota "normal" again, just remove the espidf entry.

To clarify: There are now three ways to compile Tasmota

  • with Tasmota Arduino (standard) since the beginning

  • Hybrid compile: Build customized Arduino IDF libraries (since PR Platform 2024.10.30 (Arduino core 3.1.0.241015 / IDF 5.3.1+) #22299)

  • with this PR Tasmota as an Arduino component of IDF

    • The pull request is done against the latest development branch
    • Only relevant files were touched
    • Only one feature/fix was added per PR and the code change compiles without warnings
    • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
    • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241015
    • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

since LTO is now standard in Tasmota Arduino framework
@Jason2866 Jason2866 merged commit 0f84211 into arendst:development Oct 16, 2024
59 checks passed
@Jason2866 Jason2866 deleted the rm_lto_settings branch October 16, 2024 12:09
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 7, 2024
since LTO is now standard in Tasmota Arduino framework
josef109 pushed a commit to josef109/Tasmota that referenced this pull request Nov 10, 2024
since LTO is now standard in Tasmota Arduino framework
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant