Fix(eos_cli_config_gen)!: Avoid generating invalid configuration for …

…traffic policies (#4266)

ansible_collections/arista/avd/docs/porting-guides/5.x.x.md

@@ -1112,6 +1112,14 @@ port_channel_interfaces:
 +       encapsulation: unmatched
 ```
 
+### Fix issues with flags, source/destination ports, and field set for TCP/UDP protocol under traffic-policies
+
+The change has been incorporated into `traffic-policies.j2` eos template.
+
+In AVD 4.0.0, configuring the `flags` for `UDP` protocol under traffic-policies was allowed and the configuration for `source/destination port` and `source/destination field-set` together was not generated for `TCP/UDP` protocol.
+
+As of AVD 5.0.0, the configuration of `flags` in `UDP` protocol under traffic-policies is not generated and the configuration for `source/destination port` and `field set` can be generated together for `TCP/UDP` protocol. Also, the configuration order has been fixed as per the EOS running-config.
+
 ### Removal of deprecated data models
 
 The following data model keys have been removed from `eos_cli_config_gen` in v5.0.0.

ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/traffic-policies-2.md

@@ -0,0 +1,76 @@
+# traffic-policies-2
+
+## Table of Contents
+
+- [Management](#management)
+  - [Management Interfaces](#management-interfaces)
+- [Interfaces](#interfaces)
+  - [Port-Channel Interfaces](#port-channel-interfaces)
+  - [Traffic Policies information](#traffic-policies-information)
+
+## Management
+
+### Management Interfaces
+
+#### Management Interfaces Summary
+
+##### IPv4
+
+| Management Interface | Description | Type | VRF | IP Address | Gateway |
+| -------------------- | ----------- | ---- | --- | ---------- | ------- |
+| Management1 | OOB_MANAGEMENT | oob | MGMT | 10.73.255.122/24 | 10.73.255.2 |
+
+##### IPv6
+
+| Management Interface | Description | Type | VRF | IPv6 Address | IPv6 Gateway |
+| -------------------- | ----------- | ---- | --- | ------------ | ------------ |
+| Management1 | OOB_MANAGEMENT | oob | MGMT | - | - |
+
+#### Management Interfaces Device Configuration
+
+```eos
+!
+interface Management1
+   description OOB_MANAGEMENT
+   vrf MGMT
+   ip address 10.73.255.122/24
+```
+
+## Interfaces
+
+### Port-Channel Interfaces
+
+#### Port-Channel Interfaces Summary
+
+##### L2
+
+| Interface | Description | Mode | VLANs | Native VLAN | Trunk Group | LACP Fallback Timeout | LACP Fallback Mode | MLAG ID | EVPN ESI |
+| --------- | ----------- | ---- | ----- | ----------- | ------------| --------------------- | ------------------ | ------- | -------- |
+
+#### Port-Channel Interfaces Device Configuration
+
+```eos
+!
+interface Port-Channel2
+   no switchport
+```
+
+### Traffic Policies information
+
+#### IPv6 Field Sets
+
+| Field Set Name | IPv6 Prefixes |
+| -------------- | ------------- |
+| IPv6-DEMO-1 | 11:22:33:44:55:66:77:88 |
+| IPv6-DEMO-2 | - |
+
+#### Traffic Policies Device Configuration
+
+```eos
+!
+traffic-policies
+   field-set ipv6 prefix IPv6-DEMO-1
+      11:22:33:44:55:66:77:88
+   !
+   field-set ipv6 prefix IPv6-DEMO-2
+```

ansible_collections/arista/avd/molecule/eos_cli_config_gen/documentation/devices/traffic-policies-3.md

@@ -0,0 +1,67 @@
+# traffic-policies-3
+
+## Table of Contents
+
+- [Management](#management)
+  - [Management Interfaces](#management-interfaces)
+- [Interfaces](#interfaces)
+  - [Ethernet Interfaces](#ethernet-interfaces)
+  - [Traffic Policies information](#traffic-policies-information)
+
+## Management
+
+### Management Interfaces
+
+#### Management Interfaces Summary
+
+##### IPv4
+
+| Management Interface | Description | Type | VRF | IP Address | Gateway |
+| -------------------- | ----------- | ---- | --- | ---------- | ------- |
+| Management1 | OOB_MANAGEMENT | oob | MGMT | 10.73.255.122/24 | 10.73.255.2 |
+
+##### IPv6
+
+| Management Interface | Description | Type | VRF | IPv6 Address | IPv6 Gateway |
+| -------------------- | ----------- | ---- | --- | ------------ | ------------ |
+| Management1 | OOB_MANAGEMENT | oob | MGMT | - | - |
+
+#### Management Interfaces Device Configuration
+
+```eos
+!
+interface Management1
+   description OOB_MANAGEMENT
+   vrf MGMT
+   ip address 10.73.255.122/24
+```
+
+## Interfaces
+
+### Ethernet Interfaces
+
+#### Ethernet Interfaces Summary
+
+##### L2
+
+| Interface | Description | Mode | VLANs | Native VLAN | Trunk Group | Channel-Group |
+| --------- | ----------- | ---- | ----- | ----------- | ----------- | ------------- |
+
+*Inherited from Port-Channel Interface
+
+#### Ethernet Interfaces Device Configuration
+
+```eos
+!
+interface Ethernet1
+   no switchport
+```
+
+### Traffic Policies information
+
+#### Traffic Policies Device Configuration
+
+```eos
+!
+traffic-policies
+```