Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Change lldp.receive_packet_tagged_drop from str to bool #4878

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Jan 14, 2025

Change Summary

Change lldp.receive_packet_tagged_drop from str to bool

Related Issue(s)

Fixes #4794

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Change lldp.receive_packet_tagged_drop from str to bool

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4878
# Activate the virtual environment
source test-avd-pr-4878/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@bug/lldp_receive_packet_tagged_drop#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,bug/lldp_receive_packet_tagged_drop --force
# Optional: Install AVD examples
cd test-avd-pr-4878
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 14, 2025
@laxmikantchintakindi laxmikantchintakindi force-pushed the bug/lldp_receive_packet_tagged_drop branch from d8e7816 to 3ef987b Compare January 14, 2025 10:49
@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review January 15, 2025 06:19
@laxmikantchintakindi laxmikantchintakindi requested review from a team as code owners January 15, 2025 06:19
@laxmikantchintakindi laxmikantchintakindi force-pushed the bug/lldp_receive_packet_tagged_drop branch from 3ef987b to a5a2291 Compare January 15, 2025 08:44
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jan 15, 2025
@gmuloc gmuloc merged commit 6be08f0 into aristanetworks:devel Jan 15, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Fix(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_cli_config_gen): Change lldp.receive_packet_tagged_drop from str to bool
3 participants