root command to list unverified upstream sources #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manith-arista
requested changes
Dec 16, 2024
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
2 times, most recently
from
d9a0b02 to
96ebecb
Compare
manith-arista
requested changes
Dec 18, 2024
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
96ebecb to
721253d
Compare
mkisielewski-arista
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Some questions, suggestions posted below.
Overall the function introduced here does some logic and writes a file in the end. Which makes the testing of it difficult. If the logic would be separate from writing the tests could be easier to write, stateless, and would not need to be run in a container.
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
721253d to
59cdbba
Compare
I have made some previously discussed changes to code. Now I have removed some part of code and made changes to existing ones. I think most of the review comments are addressed in these new changes. |
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
2 times, most recently
from
2b2c92b to
8e75411
Compare
manishk-arista
changed the title
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
8e75411 to
4d820ec
Compare
aajith-arista
previously approved these changes
Dec 23, 2024
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
4d820ec to
246ddfc
Compare
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
2 times, most recently
from
df0bf50 to
595661e
Compare
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
5 times, most recently
from
12695bd to
d001770
Compare
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
d001770 to
c4f8572
Compare
manith-arista
previously approved these changes
Jan 10, 2025
|
Rebase the PR with latest main branch changes |
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
c4f8572 to
3d85430
Compare
new root command is designed to list all upstream sources with the `skip-check` flag set to `true`. - If `-p <package>` is specified, it lists unverified sources for the specified package. - If <package> not forund in repo, error is thrown The output is written to stdout This will enable better tracking of unverified sources.
manishk-arista
force-pushed
the
manishk-list-unverifired-sources-rootCmd
branch
from
3d85430 to
0b47bf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New root command is designed to list all upstream sources with the
skip-checkflag set totrue.-p <package>is specified, it lists unverified sources for the specified package.The output is written to stdout
This will enable better tracking of unverified sources.