Merge pull request #65 from arkahna/feature/annotate-functions-with-n…

…o-this

Annotate with `this: void` to fix linting issue around unbound methods

.changeset/cool-schools-search.md

@@ -0,0 +1,6 @@
+---
+'@featureboard/node-sdk': minor
+'@featureboard/js-sdk': minor
+---
+
+[TypeScript] Annotated SDK functions with 'this: void' to indicate the methods can be destructured without needing to be bound

libs/js-sdk/src/client-connection.ts

@@ -11,23 +11,24 @@ export interface BrowserClient {
      *
      * @throws {Error} If the initialisation process fails an error is thrown
      */
-    waitForInitialised(): Promise<boolean>
+    waitForInitialised(this: void): Promise<boolean>
 
     /** Subscribe to initialised changes, will call back with initialised boolean value
      * Recommended to be used in conjunction with updateAudiences()
      *
      * @returns unsubscribe function
      */
     subscribeToInitialisedChanged(
+        this: void,
         callback: (initialised: boolean) => void,
     ): () => void
 
     /** Will set initialised to false until the new audiences are loaded */
-    updateAudiences(audiences: string[]): PromiseLike<void>
+    updateAudiences(this: void, audiences: string[]): PromiseLike<void>
 
     /** Manually triggers an update to the feature state */
-    updateFeatures(): PromiseLike<void>
+    updateFeatures(this: void): PromiseLike<void>
 
     /** Closes subscription to the FeatureBoard service */
-    close: () => void
+    close: (this: void) => void
 }

libs/js-sdk/src/features-client.ts

@@ -3,6 +3,7 @@ import type { FeatureBoardEffectiveStateJS } from './js-state'
 
 export interface FeatureBoardClient {
     getFeatureValue<T extends keyof Features>(
+        this: void,
         featureKey: T,
         defaultValue: Features[T],
     ): Features[T]
@@ -13,10 +14,11 @@ export interface FeatureBoardClient {
      * @returns unsubscribe function
      */
     subscribeToFeatureValue<T extends keyof Features>(
+        this: void,
         featureKey: keyof Features,
         defaultValue: Features[T],
         onValue: (value: Features[T]) => void,
     ): () => void
 
-    getEffectiveValues(): FeatureBoardEffectiveStateJS
+    getEffectiveValues(this: void): FeatureBoardEffectiveStateJS
 }

libs/node-sdk/src/server-connection.ts

@@ -11,6 +11,7 @@ export interface ServerClient {
      * immediately call back with the current value and will not subscribe to the feature in the state store.
      **/
     request(
+        this: void,
         audiences: string[],
     ): FeatureBoardClient & PromiseLike<FeatureBoardClient>
 
@@ -22,10 +23,10 @@ export interface ServerClient {
      *
      * @throws {Error} If the initialisation process fails an error is thrown
      */
-    waitForInitialised(): Promise<boolean>
+    waitForInitialised(this: void): Promise<boolean>
 
     /** Manually triggers an update to the feature state */
-    updateFeatures(): PromiseLike<void>
+    updateFeatures(this: void): PromiseLike<void>
 
-    close(): void
+    close(this: void): void
 }