Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow Fx Website Doc re-org + improvements. #2460

Merged
merged 15 commits into from
Aug 3, 2021
Merged

Arrow Fx Website Doc re-org + improvements. #2460

merged 15 commits into from
Aug 3, 2021

Conversation

nomisRev
Copy link
Member

@nomisRev nomisRev commented Jul 30, 2021 •
edited
Loading

  • Bring back Arrow Fx Coroutines patterns document from 0.11.x
  • Resource
  • CircuitBreaker
  • Quick start with Gradle setuo
  • Table Content + promote interesting functions and data types on website (references to API docs)
  • Atomic
  • Update Gradle to MPP Setup moving this to other PR.

@nomisRev nomisRev marked this pull request as ready for review August 1, 2021 16:33
@nomisRev nomisRev requested a review from a team August 1, 2021 16:33
@nomisRev nomisRev changed the title WIP: Arrow Fx Website revamp Arrow Fx Website Doc re-org + improvements. Aug 1, 2021
@nomisRev
Copy link
Member Author

nomisRev commented Aug 1, 2021

Closes #2314 & Closes #2359

raulraja
raulraja approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nomisRev , great docs and much needed 👏

arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Atomic.kt Outdated Show resolved Hide resolved
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/CircuitBreaker.kt Outdated Show resolved Hide resolved
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/CircuitBreaker.kt Outdated Show resolved Hide resolved
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/CircuitBreaker.kt Outdated Show resolved Hide resolved
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/CircuitBreaker.kt Show resolved Hide resolved
arrow-site/docs/docs/fx/coroutines/README.md Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/parallel/README.MD Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/parallel/README.MD Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/purity-and-referentially-transparent-functions/README.MD Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/purity-and-referentially-transparent-functions/README.MD Outdated Show resolved Hide resolved
@nomisRev @raulraja
Apply suggestions from code review
0d2df27 
Co-authored-by: Raúl Raja Martínez <[email protected]>
nomisRev
nomisRev commented Aug 2, 2021
View reviewed changes
Copy link
Member Author

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review @raulraja 🙏

arrow-site/docs/docs/fx/README.md Outdated Show resolved Hide resolved
1Jajen1
1Jajen1 approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@1Jajen1 1Jajen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads pretty good 👍

arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt Outdated Show resolved Hide resolved
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt Outdated Show resolved Hide resolved
arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/purity-and-referentially-transparent-functions/README.MD Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/purity-and-referentially-transparent-functions/README.MD Outdated Show resolved Hide resolved
arrow-site/docs/docs/fx/README.md Outdated Show resolved Hide resolved
nomisRev
nomisRev commented Aug 2, 2021
View reviewed changes
Copy link
Member Author

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough review @1Jajen1 🙏

@nomisRev nomisRev merged commit 9d67157 into main Aug 3, 2021
@nomisRev nomisRev deleted the sv-docs branch August 3, 2021 06:43
@nomisRev nomisRev mentioned this pull request Aug 3, 2021
Closed
@nomisRev nomisRev mentioned this pull request Aug 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmoynihan kmoynihan kmoynihan left review comments

@raulraja raulraja raulraja approved these changes

@1Jajen1 1Jajen1 1Jajen1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nomisRev @raulraja @1Jajen1 @kmoynihan