Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Implement AshGraphql.Error for AshAuthentication errors. #237

Merged
merged 1 commit into from
Nov 14, 2024
Merged

improvement: Implement AshGraphql.Error for AshAuthentication errors. #237

merged 1 commit into from
Nov 14, 2024

Conversation

jimsynz
Copy link
Contributor

@jimsynz jimsynz commented Nov 12, 2024

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@jimsynz jimsynz requested a review from barnabasJ November 12, 2024 02:27
@jimsynz jimsynz force-pushed the improvement/add-ash-auth-errors branch from 1b7244f to e780ef9 Compare November 12, 2024 02:44
@jimsynz
Copy link
Contributor Author

jimsynz commented Nov 12, 2024

@sevenseacat relevant to your interests.

@sevenseacat
Copy link
Contributor

Very relevant to my interests! :shipit:

@jimsynz jimsynz merged commit 32d1c1b into main Nov 14, 2024
17 checks passed
@jimsynz jimsynz deleted the improvement/add-ash-auth-errors branch November 14, 2024 19:33
@zachdaniel
Copy link
Contributor

I think I'd rather have this in ash authentication than here TBH. There will be equivalent impls for AshJsonApi errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnabasJ barnabasJ barnabasJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimsynz @sevenseacat @zachdaniel @barnabasJ