Skip to content

Commit

Permalink
Consistent vector store property prefix for Chroma store
Browse files Browse the repository at this point in the history
* The Chroma vector store config property prefix uses .store at the end
  which is not consistent with the other vector stores - fixing this.

* Update the upgrade-notes.adoc
  • Loading branch information
sobychacko authored and markpollack committed Jun 26, 2024
1 parent 0f93828 commit b206b37
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ spring.ai.vectorstore.chroma.client.username=<your username (if configure)>
spring.ai.vectorstore.chroma.client.password=<your password (if configure)>
# Chroma Vector Store collection properties
spring.ai.vectorstore.chroma.store.collection-name=<your collection name>
spring.ai.vectorstore.chroma.collection-name=<your collection name>
# Chroma Vector Store configuration properties
Expand Down Expand Up @@ -116,7 +116,7 @@ You can use the following properties in your Spring Boot configuration to custom
|`spring.ai.vectorstore.chroma.client.key-token`| Access token (if configured) | -
|`spring.ai.vectorstore.chroma.client.username`| Access username (if configured) | -
|`spring.ai.vectorstore.chroma.client.password`| Access password (if configured) | -
|`spring.ai.vectorstore.chroma.store.collection-name`| Collection name | `SpringAiCollection`
|`spring.ai.vectorstore.chroma.collection-name`| Collection name | `SpringAiCollection`
|===

[NOTE]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
[[upgrade-notes]]
= Upgrading Notes

== Upgrading to 1.0.0.M2

* The configuration prefix for the Chroma Vector Store has been changes from `spring.ai.vectorstore.chroma.store` to `spring.ai.vectorstore.chroma` in order to align with the naming conventions of other vector stores.

== Upgrading to 1.0.0.M1

On our march to release 1.0.0 M1 we have made several breaking changes. Apologies, it is for the best!
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023 - 2024 the original author or authors.
* Copyright 2023-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand All @@ -21,11 +21,12 @@

/**
* @author Christian Tzolov
* @author Soby Chacko
*/
@ConfigurationProperties(ChromaVectorStoreProperties.CONFIG_PREFIX)
public class ChromaVectorStoreProperties extends CommonVectorStoreProperties {

public static final String CONFIG_PREFIX = "spring.ai.vectorstore.chroma.store";
public static final String CONFIG_PREFIX = "spring.ai.vectorstore.chroma";

private String collectionName = ChromaVectorStore.DEFAULT_COLLECTION_NAME;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public class ChromaVectorStoreAutoConfigurationIT {
.withUserConfiguration(Config.class)
.withPropertyValues("spring.ai.vectorstore.chroma.client.host=http://" + chroma.getHost(),
"spring.ai.vectorstore.chroma.client.port=" + chroma.getMappedPort(8000),
"spring.ai.vectorstore.chroma.store.collectionName=TestCollection");
"spring.ai.vectorstore.chroma.collectionName=TestCollection");

@Test
public void addAndSearchWithFilters() {
Expand Down

0 comments on commit b206b37

Please sign in to comment.