Allow some textures to be animated even if tx animation is globally disabled #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isabled. Allow minecraft by default
asiekierka
reviewed
Mar 13, 2019
| @@ -303,9 +303,6 @@ public static void init() { | |||
| handlerCN.add(new EntityDataManagerPatch(), "net.minecraft.network.datasync.EntityDataManager"); | |||
| } | |||
|
|
|||
| patchy.addTransformerId("disableTextureAnimations_v1"); | |||
There was a problem hiding this comment.
This breaks disabling texture animations when FoamFix's texture sprite patches are disabled... as well as a fast global disable...
I like the idea, though - I might do an implementation myself at a point.
There was a problem hiding this comment.
You are right. I know this approach is far from perfect, but it is enough for what I need for my own experience, and I thought I might as well share it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows e.g. minecraft's textures to remain animated, while all others are disabled.
This is benificial, as with the default resource pack there aren't that many animated blocks, but you quickly notice the ones that are animated if it is disabled (e.g. Water, Fire)