Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: resolve_json_module with transpiler #747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Dec 9, 2024

To show how a transpiler needs to handle .json source files.

See also: aspect-build/rules_swc#287


Changes are visible to end-users: no

Test plan

  • New test cases added

Copy link

aspect-workflows bot commented Dec 9, 2024

Test

12 test targets passed

Targets
//examples/linked_consumer:pkg_no_typechecking [k8-fastbuild]                               172ms
//examples/resolve_json_module_esm:ts-dict-override_typecheck_test [k8-fastbuild]           40ms
//examples/resolve_json_module_esm:ts-dict-unspecified_typecheck_test [k8-fastbuild]        25ms
//examples/resolve_json_module_esm:ts-with-json-dict-override [k8-fastbuild]                100ms
//examples/resolve_json_module_esm:ts-with-json-dict-unspecified [k8-fastbuild]             91ms
//examples/resolve_json_module_transpiler:test [k8-fastbuild]                               29ms
//examples/resolve_json_module_transpiler:ts-dict-override_typecheck_test [k8-fastbuild]    41ms
//examples/resolve_json_module_transpiler:ts-dict-unspecified_typecheck_test [k8-fastbuild] 44ms
//examples/resolve_json_module_transpiler:ts-with-json [k8-fastbuild]                       93ms
//examples/resolve_json_module_transpiler:ts-with-json-dict-override [k8-fastbuild]         99ms
//examples/resolve_json_module_transpiler:ts-with-json-dict-unspecified [k8-fastbuild]      85ms
//examples/resolve_json_module_transpiler:ts_typecheck_test [k8-fastbuild]                  60ms

Total test execution time was 879ms. 153 tests (92.7%) were fully cached saving 9s.


Buildifier      Format

@jbedard jbedard force-pushed the ts_project-transpiler-json branch from 914d539 to 6ccacb9 Compare January 8, 2025 23:20
Copy link

aspect-workflows bot commented Jan 8, 2025

Test

⚠️ Buildkite build #46 failed.

//examples/project_references/lib_b:lib_b failed to build

TsProjectEmit returned a non-zero exit code when running remotely
 
Action details (uncached result): http://localhost:7984/blobs/sha256/historical_execute_response/8bcf35aa7455519cdef167b7a614d4e056cf889aa58f2c2ab77c2699764c3ba1-1374/

💡 To reproduce the build failures, run

bazel build --output_groups=+types //examples/project_references/lib_b:lib_b

Buildifier

Buildifier managed files require formatting

--- ./examples/project_references/lib_b/BUILD.bazel	2025-01-10 20:09:44.216503173 +0000
+++ /tmp/buildifier-tmp-1497893204	2025-01-10 20:09:52.416519684 +0000
@@ -8,8 +8,8 @@
     srcs = ["index.ts"],
     composite = True,
     declaration = True,
-    isolated_typecheck = True,
     extends = "//examples/project_references:tsconfig-base",
+    isolated_typecheck = True,
     deps = ["//examples/project_references/lib_a"],
 )
 

💡 Run the following to apply the suggested formatting fixes

bazel run //:buildifier

Format

Formatting check has failed

💡 Some formatting failures can be fixed automatically by running the command below, while others may require manual fixes

bazel run //:format -- examples/project_references/lib_b/BUILD.bazel

ℹ️ A patch file containing the changes has been archived as an artifact of this build

@jbedard jbedard force-pushed the ts_project-transpiler-json branch from 6ccacb9 to a20f6a2 Compare January 9, 2025 19:49
@jbedard jbedard force-pushed the ts_project-transpiler-json branch from a20f6a2 to 07d0a38 Compare January 10, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants