Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create rule asyncapi3-channel-servers for v3 core ruleset #1073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dishafaujdar
Copy link

@dishafaujdar dishafaujdar commented Jan 5, 2025

This PR creates the rule asyncapi3-channel-servers for the v3 core ruleset.

Resolves #1020

Copy link

changeset-bot bot commented Jan 5, 2025

🦋 Changeset detected

Latest commit: e552578

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

sonarqubecloud bot commented Jan 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
75.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@dishafaujdar dishafaujdar changed the title feat: create rule asyncapi3-channel-servers for v3 core ruleset feat: create rule asyncapi3-channel-servers for v3 core ruleset Jan 5, 2025
@dishafaujdar
Copy link
Author

dishafaujdar commented Jan 5, 2025

The file packages/parser/src/ruleset/v3/functions/channelServers.ts was copied from packages/parser/src/ruleset/v2/functions/channelServers.ts, so it will be duplicated in any case. Should I add some kind of exclusion for SonarCloud?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the rule asyncapi3-channel-servers for the v3 core ruleset
1 participant