Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add asynchronix-util crate #53

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add asynchronix-util crate #53

merged 3 commits into from
Oct 31, 2024

Conversation

jauhien
Copy link
Contributor

@jauhien jauhien commented Oct 31, 2024

No description provided.

@jauhien jauhien requested a review from sbarral October 31, 2024 14:02

/// Observable state.
///
/// This struct incapsulates state. Every state change is propagated to the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

struct -> object
incapsulates -> encapsulates

self.out.send(self.state.observe()).await;
r
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't there be a propagate method, in particular if the user wants to propagate the (default-constructed) state in Model::init()?

@sbarral sbarral merged commit 06079bd into main Oct 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants