Add camera #39
Merged
Add camera #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
bobvandevijver
requested changes
Aug 7, 2024
JELoohuis
force-pushed
the
add-camera
branch
4 times, most recently
from
c9f8252 to
7433e40
Compare
bobvandevijver
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the camera category of devices.
The camera device class is quite extensive, and some parts quite complex to integrate with Homey, so I stuck to those that could be readily tested with my device.
Images are not yet supported due to Homey not having the correct rights in the Tuya API.
It may be possible to decrypt the images sent in event messages, but this will require figuring out the exact encryption parameters used.
The key for this is readily available through the Tuya API as local_key in the device details.
Since the camera device class has a huge amount of capabilities,
those that were deemed unlikely to be changed by hand often were implemented as settings.
For those settings that may be changed semi-regularly flows were added.
This is of course a compromise, as the settings that are not applicable cannot be disabled, unlike capabilities.
The zoom control/stop and battery level are not supported by my test device, so they are untested.
It would be nice to receive feedback on these from people with devices that do support them.