Fix early close of socket in http_server #1496
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket can close too fast for some clients, as exhibited on FreeBSD in recent failing CI tests: https://github.com/atomvm/AtomVM/actions/runs/12977426531/job/36190827478#step:3:5747 Fixed by adding a 5000 ms delay before closing the socket. Signed-off-by: Winford <[email protected]>
bettio
reviewed
Jan 27, 2025
| @@ -77,7 +77,10 @@ reply(StatusCode, ReplyBody, Conn) -> | |||
| StatusCode, ReplyBody, [<<"Content-Type: text/html\r\nConnection: close\r\n">>], Conn | |||
| ), | |||
| Socket = proplists:get_value(socket, NewConn), | |||
| gen_tcp:close(Socket), | |||
| spawn_link(fun() -> | |||
| timer:sleep(5000), | |||
There was a problem hiding this comment.
This sounds quite odd, we are hanging for 5 seconds before closing the socket.
Do we have any open issue about the root cause we are trying to fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket can close too fast for some clients, as exhibited on FreeBSD in recent failing CI tests: https://github.com/atomvm/AtomVM/actions/runs/12977426531/job/36190827478#step:3:5747 Fixed by adding a 5000 ms delay before closing the socket.
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later