Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated for Swift 3.0 #2

Closed
wants to merge 1 commit into from
Closed

Conversation

colemancda
Copy link
Contributor

No description provided.

@colemancda
Copy link
Contributor Author

fixes #1

@lorentey
Copy link
Collaborator

lorentey commented Apr 6, 2016

Great work! I need to keep the package working under Swift 2.2, so I'm going to merge this into a new branch.

@colemancda
Copy link
Contributor Author

Thanks. :)

Coleman,

On Apr 6, 2016, at 5:13 AM, Károly Lőrentey [email protected] wrote:

Great work! I need to keep the package working under Swift 2.2, so I'm going to merge this into a new branch.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub #2 (comment)

@lorentey
Copy link
Collaborator

lorentey commented Apr 6, 2016

Ah, I created a swift3 branch, but I can't seem to retarget the PR myself. :-( Would you mind rebasing the PR onto that branch?

@colemancda
Copy link
Contributor Author

I can't seem to rebase it either. :(

@lorentey
Copy link
Collaborator

lorentey commented Apr 6, 2016

Bummer. I will manually apply the PR onto the branch then.

@lorentey
Copy link
Collaborator

lorentey commented Apr 6, 2016

Done! I'll merge the swift3 branch into master when Swift 3 is out. Meanwhile, we can publish prerelease versions of Deque v2 directly from the swift3 branch, so that it is possible to use Deque with Swift 3's SPM.

The unit tests will still need to be updated before the first such release, though.

@lorentey lorentey closed this Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants