chore: update dependencies #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmah42
reviewed
Jan 12, 2024
crates/validation/macros/src/lib.rs
Outdated
| @@ -108,6 +108,7 @@ pub fn validated_type(input: TokenStream) -> TokenStream { | |||
| #validated_type_ident, | |||
| ::validation::ValidationError | |||
| > { | |||
| panic!("here"); | |||
There was a problem hiding this comment.
Yeah 😞 There may be a few instances of this before the PR is marked ready. Most of the advice I found when searching how to debug macro issues was along the lines of "just add debug statements until you figure it out."
If anyone has a better way to debug macros, please let me know.
There was a problem hiding this comment.
no, that's about how i do it.
no worries about giving up on some of the packages. we can do those one-by-one.
dmah42
previously approved these changes
Jan 14, 2024
|
merged in some other PRs and i think i got the merge right here. hopefully it doesn't make things harder for you. |
|
manually merged Cargo.lock :/ |
Merged
|
we just did a big dependency update in #496 so i'm going to close this in deference to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.