Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling issue in Flutter QS #10326

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Oct 31, 2023

Changes

Currently, the Flutter interactive QuickStarts for mobile and web have an issue when scrolling past the first "Getting Started" step, whereas the content of the following step remains dimmed:

Screen.Recording.2023-10-31.at.13.16.07.mov

Turns out that the step whose content remains dimmed is added through an include. This include contains a level 2 heading with the name of the step ("Configure Auth0"), and is being included after another level 2 heading ("Getting Started"). While this should result (and does result) in a new level 2 heading being appended, it trips up the scroll behavior of the docs app.

This PR simply removes the "Getting Started" heading so that the includes follow after a level 1 heading, which does not cause any issues when scrolling. This is intended as a stop-gap measure until the underlying issue is fixed on the docs app.

@Widcket Widcket requested a review from a team as a code owner October 31, 2023 13:25
@Widcket Widcket merged commit 192de65 into master Nov 6, 2023
2 checks passed
@Widcket Widcket deleted the qs/fix-flutter-scroll-issue branch November 6, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants