Updated to support visionOS #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heckj
reviewed
May 24, 2024
| @@ -11,7 +11,7 @@ if ProcessInfo.processInfo.environment["LOCAL_BUILD"] != nil { | |||
|
|
|||
| let package = Package( | |||
| name: "automerge-repo", | |||
| platforms: [.iOS(.v16), .macOS(.v13)], | |||
| platforms: [.iOS(.v16), .macOS(.v13), .visionOS(.v1)], | |||
There was a problem hiding this comment.
not strictly needed, but doesn't hurt anything to have it here
heckj
approved these changes
May 24, 2024
heckj
reviewed
May 24, 2024
| @@ -36,7 +36,7 @@ public struct PeerToPeerProviderConfiguration: Sendable { | |||
| if let auto = autoconnect { | |||
| self.autoconnect = auto | |||
| } else { | |||
| #if os(iOS) | |||
| #if os(iOS) || os(visionOS) | |||
There was a problem hiding this comment.
Just to be sure before I merge this - this means the default peer to peer connection will automatically try to connect to any visible peers as a default setting. I'm good with it, as it can be overridden in code, but I wanted to double-check before I merge.
There was a problem hiding this comment.
That's the default with iOS so I thought it should be the same for visionOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated package to support visionOS