Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocketProvider accepts an URLRequest to connect #122

Merged
merged 1 commit into from
Nov 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions Sources/AutomergeRepo/Networking/Providers/WebSocketProvider.swift
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ internal import OSLog
/// An Automerge-repo network provider that connects to other repositories using WebSocket.
@AutomergeRepo
public final class WebSocketProvider: NetworkProvider {
public typealias NetworkConnectionEndpoint = URL

/// The name of this provider.
public let name = "WebSocket"

Expand All @@ -22,7 +24,7 @@ public final class WebSocketProvider: NetworkProvider {
var ongoingReceiveMessageTask: Task<Void, any Error>?
var config: WebSocketProviderConfiguration
// reconnection logic variables
var endpoint: URL?
var endpoint: URLRequest?
var peered: Bool

private let _statePublisher: CurrentValueSubject<WebSocketProviderState, Never> =
Expand All @@ -49,7 +51,16 @@ public final class WebSocketProvider: NetworkProvider {
}

/// Initiate an outgoing connection.
///
/// Create a default `URLRequest` and create a WebSocket connection with it.
public func connect(to url: URL) async throws {
try await connect(to: URLRequest(url: url))
}

/// Initiate an outgoing connection.
///
/// Create a WebSocket connection with the provided `URLRequest`.
public func connect(to request: URLRequest) async throws {
if peered {
Logger.websocket.error("Attempting to connect while already peered")
throw Errors.NetworkProviderError(msg: "Attempting to connect while already peered")
Expand All @@ -60,13 +71,13 @@ public final class WebSocketProvider: NetworkProvider {
throw Errors.NetworkProviderError(msg: "Attempting to connect before connected to a delegate")
}

if try await attemptConnect(to: url) {
if config.logLevel.canTrace() {
if try await attemptConnect(to: request) {
if config.logLevel.canTrace(), let url = request.url {
Logger.websocket.trace("WEBSOCKET: connected to \(url)")
}
endpoint = url
endpoint = request
} else {
if config.logLevel.canTrace() {
if config.logLevel.canTrace(), let url = request.url {
Logger.websocket.trace("WEBSOCKET: failed to connect to \(url)")
}
return
Expand Down Expand Up @@ -200,15 +211,16 @@ public final class WebSocketProvider: NetworkProvider {
}

// Returns a `true` on success OR throws an error (log the error, but can retry)
func attemptConnect(to url: URL?) async throws -> Bool {
private func attemptConnect(to request: URLRequest?) async throws -> Bool {
precondition(peered == false)
guard let url,
guard let request,
let url = request.url,
let peerId,
let delegate
else {
if config.logLevel.canTrace() {
Logger.websocket.trace("Pre-requisites not available for attemptConnect, returning nil")
Logger.websocket.trace("URL: \(String(describing: url))")
Logger.websocket.trace("URL: \(String(describing: request?.url))")
Logger.websocket.trace("PeerID: \(String(describing: self.peerId))")
Logger.websocket.trace("Delegate: \(String(describing: self.delegate))")
}
Expand All @@ -217,7 +229,6 @@ public final class WebSocketProvider: NetworkProvider {

// establish the WebSocket connection

let request = URLRequest(url: url)
let webSocketTask = URLSession.shared.webSocketTask(with: request)
if config.logLevel.canTrace() {
Logger.websocket.trace("WEBSOCKET: Activating websocket to \(url, privacy: .public)")
Expand Down Expand Up @@ -258,7 +269,7 @@ public final class WebSocketProvider: NetworkProvider {
peeredConnections = [peerConnectionDetails]
// these need to be set _before_ we send the delegate message that we're
// peered, because that process in turn (can trigger/triggers) a sync
endpoint = url
endpoint = request
self.webSocketTask = webSocketTask

await delegate.receiveEvent(event: .ready(payload: peerConnectionDetails))
Expand Down
Loading