Fix use of config #133
Merged
Fix use of config #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, undo most of the (unnecessary) changes made in #103, which were done to allow accessing the attributes of config when using the API mode, e.g. executing
examples/api/importances.py.The reason using the API mode did not work was that config was only added to the deepcave-attributes when executing server.py, which is not the case when running the API examples. Thus,
from deepcave import configfailed in these cases.So now, instead of importing the Config class via
from deepcave.config import Config, config is always added to the deepcave-attributes, such that it is available when running the API examples as well.