Cleaning up TestKit. #1010
Merged
Cleaning up TestKit. #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
commented
Oct 29, 2023
| @@ -12,7 +12,7 @@ public abstract class AbstractGradleProject @JvmOverloads constructor( | |||
| buildPath: String = "build/functionalTest", | |||
| ) { | |||
|
|
|||
| protected fun newGradleProjectBuilder(): GradleProject.Builder { | |||
| protected open fun newGradleProjectBuilder(): GradleProject.Builder { | |||
There was a problem hiding this comment.
Not super happy with this, but it solved a problem quickly.
autonomousapps
commented
Oct 29, 2023
| sources = emptyList() | ||
| } | ||
| } | ||
|
|
||
| private fun defaultRootProjectBuildScript(): BuildScript { | ||
| return BuildScript( | ||
| plugins = Plugins(listOf(Plugin.dependencyAnalysis, Plugin.kotlinPlugin(apply = false))) |
There was a problem hiding this comment.
The included build projects should do this more centrally than how I've solved it currently.
autonomousapps
commented
Oct 29, 2023
autonomousapps
commented
Oct 29, 2023
testkit/src/main/kotlin/com/autonomousapps/kit/android/AndroidSubproject.kt
Show resolved
Hide resolved
autonomousapps
commented
Oct 29, 2023
| builder.withSubprojectInIncludedBuild('second-build', 'second-sub1') { secondSub -> | ||
| builder.withSubprojectInIncludedBuild( | ||
| 'second-build', | ||
| [Plugins.dependencyAnalysis, Plugins.kotlinNoApply], |
There was a problem hiding this comment.
Make this nicer somehow?
autonomousapps
commented
Oct 29, 2023
| @@ -30,8 +31,8 @@ final class IncludedBuildWithDivergingPluginClasspathsProject extends AbstractPr | |||
| } | |||
| builder.withIncludedBuild('second-build') { second -> | |||
| second.withBuildScript { bs -> | |||
| bs.plugins.add(Plugin.javaLibrary) | |||
| if (divergingPluginClasspaths) bs.plugins.add(Plugin.springBoot) | |||
| bs.plugins = [Plugins.dependencyAnalysis, Plugins.kotlinNoApply, Plugin.javaLibrary] | |||
There was a problem hiding this comment.
Make this nicer somehow?
autonomousapps
commented
Oct 29, 2023
| builder.withSubprojectInIncludedBuild('processor-build', 'sub-processor1') { secondSub -> | ||
| builder.withSubprojectInIncludedBuild( | ||
| 'processor-build', | ||
| [Plugins.dependencyAnalysis, Plugins.kotlinNoApply], |
autonomousapps
commented
Oct 29, 2023
| @@ -42,7 +46,7 @@ final class IncludedBuildProject extends AbstractProject { | |||
| } | |||
| builder.withIncludedBuild('second-build') { second -> | |||
| second.withBuildScript { bs -> | |||
| bs.plugins.add(Plugin.javaLibrary) | |||
| bs.plugins = [Plugins.dependencyAnalysis, Plugins.kotlinNoApply, Plugin.javaLibrary] | |||
|
Build failed |
autonomousapps
changed the title
They don't belong in the library, since they make too many assumptions.
autonomousapps
force-pushed
the
trobalik.testkit
branch
from
3451a4a to
64522ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.