feat: improve output of ProjectGraphTask and include topological sort. #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
autonomousapps
changed the title
autonomousapps
commented
Nov 27, 2024
src/main/kotlin/com/autonomousapps/internal/graph/GraphWriter.kt
Outdated
Show resolved
Hide resolved
|
❌ Test workflow failed: |
|
❌ Test workflow failed: |
autonomousapps
commented
Dec 2, 2024
There was a problem hiding this comment.
Need to publish a new version of graph-support before I can merge.
autonomousapps
commented
Dec 2, 2024
|
|
||
| final class WorkPlanSpec extends AbstractJvmSpec { | ||
|
|
||
| @PendingFeature |
There was a problem hiding this comment.
Fix test or delete feature and test.
autonomousapps
commented
Dec 2, 2024
Comment on lines
+49
to
+69
| /** | ||
| * Returns the [graph] sorted into topological order, ascending. Each node in the graph is paired with its depth. | ||
| * | ||
| * TODO(tsr): shortest path is wrong, I need the _longest_ path. | ||
| */ | ||
| fun topological(graph: Graph<Coordinates>): String { | ||
| val root = graph.root() | ||
| val top = graph.topological(root) | ||
| // val paths = graph.shortestPaths(root) | ||
|
|
||
| return buildString { | ||
| top.forEach { node -> | ||
| appendLine(node.maybeProjectCoordinates(buildPath).gav()) | ||
| // append(" ") | ||
| // appendLine("${paths.distanceTo(node)}") | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // TODO replace with Hu's algorithm (for scheduling concurrent work), and push relevant bits into Graphs.kt. | ||
| fun workPlan(graph: Graph<Coordinates>): String { |
|
❌ Test workflow failed: |
autonomousapps
force-pushed
the
trobalik.topo
branch
from
a17103e to
551a52e
Compare
|
❌ Test workflow failed: |
autonomousapps
force-pushed
the
trobalik.topo
branch
from
551a52e to
1a4efb8
Compare
|
❌ Test workflow failed: |
1. improve output of ProjectGraphTask. 2. generate merged graph of all variants in a project. 3. generate merged graph for entire build. 4. incubating support for generating work plan.
autonomousapps
force-pushed
the
trobalik.topo
branch
from
1a4efb8 to
7b23159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a follow-up, I will add a task at the root level for doing this globally in one pass.