Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update images in the tutorial pages #634

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

vish0012
Copy link

@vish0012 vish0012 commented Dec 16, 2024

Description

The images in tutorials pages were using old RVIZ plugins. This PR updates the page with the latest RVIZ view to have less confusion to the users following the page.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mitsudome-r
Copy link
Member

mitsudome-r commented Dec 18, 2024

@vish0012
Could you update your PR title and description so that reviewers could understand what this PR is about?
I know it's mainly for updating images with the latest rviz, but it would be nice if you can update them for best practice.

@mitsudome-r mitsudome-r self-requested a review December 18, 2024 05:29
@mitsudome-r mitsudome-r changed the title Updoc vishal docs: update images in the tutorial pages Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants