Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrm_handler): mrm handler publish emergecy holding #9285

Conversation

TetsuKawa
Copy link
Contributor

@TetsuKawa TetsuKawa commented Nov 11, 2024

Description

Originally, the emergency_holding function that the system_error_monitor had was moved to the mrm_handler. However, the mrm_handler does not publish the emergency_holding state, so the emergency_holding in the hazard_status published by the hazard_status_converter is not updated.

This PR add emergency holding publisher which is publish a value of is_emergency_holding_ .

Related links

Parent Issue:

Related PR

How was this PR tested?

test/update-emergency-holding-state is include This PR, #9287 and tier4/tier4_autoware_msgs#153.

Screencast.from.2024.11.11.14.34.38.webm

Confirmed that /system/emergency_hoding is published and update emergency_hoding in /system/emergency/hazard_status.

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Pub /system/emergency_holding tier4_system_msgs/msg/EmergencyHoldingState indicates whether mrm is in the emergency_holding state

Effects on system behavior

None.

@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Nov 11, 2024
Copy link

github-actions bot commented Nov 11, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TetsuKawa TetsuKawa marked this pull request as draft November 11, 2024 06:04
@TetsuKawa TetsuKawa marked this pull request as ready for review November 11, 2024 06:45
@TetsuKawa TetsuKawa self-assigned this Nov 11, 2024
@TetsuKawa TetsuKawa added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 11, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.16%. Comparing base (663fe98) to head (af53257).
Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
...m/mrm_handler/src/mrm_handler/mrm_handler_core.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9285      +/-   ##
==========================================
- Coverage   29.17%   29.16%   -0.02%     
==========================================
  Files        1336     1336              
  Lines      103038   103028      -10     
  Branches    39954    39945       -9     
==========================================
- Hits        30059    30045      -14     
- Misses      70031    70037       +6     
+ Partials     2948     2946       -2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.16% <ø> (-0.01%) ⬇️ Carriedforward from 663fe98

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TetsuKawa TetsuKawa merged commit c6c3b1c into autowarefoundation:main Nov 14, 2024
58 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Nov 14, 2024
…dation#9285)

* feat: add publisher for emrgency holding

Signed-off-by: TetsuKawa <[email protected]>

* modify: fix msg element

Signed-off-by: TetsuKawa <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: TetsuKawa <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants