-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mrm_handler): mrm handler publish emergecy holding #9285
feat(mrm_handler): mrm handler publish emergecy holding #9285
Conversation
Signed-off-by: TetsuKawa <[email protected]>
Signed-off-by: TetsuKawa <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9285 +/- ##
==========================================
- Coverage 29.17% 29.16% -0.02%
==========================================
Files 1336 1336
Lines 103038 103028 -10
Branches 39954 39945 -9
==========================================
- Hits 30059 30045 -14
- Misses 70031 70037 +6
+ Partials 2948 2946 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…dation#9285) * feat: add publisher for emrgency holding Signed-off-by: TetsuKawa <[email protected]> * modify: fix msg element Signed-off-by: TetsuKawa <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: TetsuKawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Originally, the emergency_holding function that the system_error_monitor had was moved to the mrm_handler. However, the mrm_handler does not publish the emergency_holding state, so the emergency_holding in the hazard_status published by the hazard_status_converter is not updated.
This PR add emergency holding publisher which is publish a value of
is_emergency_holding_
.Related links
Parent Issue:
Related PR
How was this PR tested?
test/update-emergency-holding-state is include This PR, #9287 and tier4/tier4_autoware_msgs#153.
Screencast.from.2024.11.11.14.34.38.webm
Confirmed that
/system/emergency_hoding
is published and updateemergency_hoding
in/system/emergency/hazard_status
.Notes for reviewers
None.
Interface changes
Topic changes
Additions and removals
/system/emergency_holding
tier4_system_msgs/msg/EmergencyHoldingState
Effects on system behavior
None.