Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(control_data_collecting_tool): add masks to specify data collection range #167

Merged
merged 49 commits into from
Dec 5, 2024
Merged

feat(control_data_collecting_tool): add masks to specify data collection range #167

merged 49 commits into from
Dec 5, 2024

Conversation

YoshihiroKogure
Copy link
Contributor

@YoshihiroKogure YoshihiroKogure commented Dec 3, 2024 •
edited
Loading

Description

In this PR, a mask and a tool for creating the mask were developed to specify the data collection area on the heatmap.

  • When the node is launched, the pop-up window displays the data collection area specified by the mask as cells highlighted in blue within the velocity-acceleration heatmap, velocity-steering angle heatmap, and velocity-steer rate heatmap. Additionally, cells where data has been collected beyond a certain threshold will change to green.

Screenshot from 2024-12-03 13-14-03

Screenshot from 2024-12-03 13-15-42

  • Additionally, users can specify the mask themselves. For details on how to modify the mask, please refer to the README linked here.

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshihiroKogure and others added 30 commits November 20, 2024 12:25
@YoshihiroKogure
Add trajectory inside circle
98cfbb1 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Fix bug
6305aa5 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Add lanelet2 trajectory
43316cf 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
pre-commit run
40c6c9c 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Fix bug
a9d671a 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
pre-commit
5d8654a 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update README.md
61312ec 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Add parameter descriptions to the README
4adc140 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
063f281
@YoshihiroKogure
Revise the content
1e31241 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
2d954d8
@YoshihiroKogure
Update README
ebd457e 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update README
5f7df16 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Add comments
d3b8e37 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update prameters for along_road course
7014de7 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
80e95a8
@YoshihiroKogure
Add default mask and mask selector
2362225 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Add mask to plotter
08bc15e 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Data collection concerning Mask
857f08b 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Modify the code to publish the pose
36ee806 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
9f6e7ef
@YoshihiroKogure
Modify to work even when map_path is not provided
ef6afa9 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Add steer rate plot
c6d6cfb 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update README.md and fix typo
3537a91 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Changes to the README and parameter values
42e524e 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@kosuke55
fix markdownlint
fa6c2a7 
Signed-off-by: kosuke55 <[email protected]>
@kosuke55
ignore prettier
b5a4630 
Signed-off-by: kosuke55 <[email protected]>
@YoshihiroKogure
Fix typo
edf18ab 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@pre-commit-ci
style(pre-commit): autofix
57856fa
@YoshihiroKogure
Add cpell:ignore
31449f9 
Signed-off-by: Yoshihiro Kogure <[email protected]>
YoshihiroKogure and others added 13 commits December 3, 2024 00:24
@YoshihiroKogure
Merge branch 'main' into feat/trajectory_inside_circle_and_lanelet2_t…
50f46bd 
…rajectory
@YoshihiroKogure
Merge branch 'feat/default_mask' into feat/trajectory_inside_circle_a…
d372051 
…nd_lanelet2_trajectory
@YoshihiroKogure
Merge pull request #8 from YoshihiroKogure/feat/trajectory_inside_cir…
5b68e95 
…cle_and_lanelet2_trajectory

Feat/trajectory inside circle and lanelet2 trajectory
@YoshihiroKogure
Add jerk heatmap and update README
29f13ae 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Merge branch 'feat/default_mask' into feat/data_collection_mask
8a51fb6
@YoshihiroKogure
Merge pull request #9 from YoshihiroKogure/feat/data_collection_mask
bdafd86 
Merge main branch into feature branch
@YoshihiroKogure
Fix bug
263c85b 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Fix bug
9eef17c 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update README
2cc7c2b 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Run pre-commit
2913d33 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update README
1b3d3a9 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Modify README.md
82f52db 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Update README.md
8abcb93 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@kosuke55 kosuke55 changed the title feat(control_data_collecting_tool): Add masks to specify data collection range feat(control_data_collecting_tool): add masks to specify data collection range Dec 3, 2024
@kosuke55
Copy link
Contributor

kosuke55 commented Dec 3, 2024

works well! thanks!

image

image

image

@kosuke55 kosuke55 changed the title feat(control_data_collecting_tool): add masks to specify data collection range feat(control_data_collecting_tool): add masks to specify data collection range Dec 3, 2024
@YoshihiroKogure YoshihiroKogure mentioned this pull request Dec 4, 2024
Merged
@YoshihiroKogure
Fix README.md
3aadd05 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure
Renaming an argument
aa8bbac 
Signed-off-by: Yoshihiro Kogure <[email protected]>
@YoshihiroKogure YoshihiroKogure mentioned this pull request Dec 5, 2024
Merged
@kosuke55 kosuke55 merged commit 7ad77ad into autowarefoundation:main Dec 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosuke55 kosuke55 kosuke55 approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

Assignees
No one assigned
Labels
tag:run-build-and-test-differential type:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YoshihiroKogure @kosuke55