Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lanelet2_map_validator): restore missing intersection lane and removed unnecessary linestrings from intersection test maps #188

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Jan 7, 2025

Description

I found that one of the intersection lanes were removed by accident.
This PR restores that lane and removed unnecessary linestrings from intersection test maps.

Screenshot from 2025-01-07 12-26-24
The left figure is the current basic_intersection_area.osm. The red rectangle implies the missing lane.
The right figure is the one fixed in this PR.

How was this PR tested?

Checked that following command runs without errors.

colcon test --packages-select autoware_lanelet2_map_validator --event-handlers console_cohesion+

Notes for reviewers

The two maps below have large changes since they were not made from vector map builder but have been edited through vector map builder in this PR.

  • basic_intersection_area.osm
  • intersection_area_with_wrong_orientation.osm

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@soblin soblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@TaikiYamada4 TaikiYamada4 merged commit 7fdfd59 into autowarefoundation:main Jan 9, 2025
27 checks passed
@TaikiYamada4 TaikiYamada4 deleted the fix/lanelet2_map_validator/restore_missing_intersection_lane branch January 9, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants