Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoware_lanelet2_map_validator): update usage #191

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Jan 8, 2025

Description

update cli usage

How was this PR tested?

document PR

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 8, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@TaikiYamada4 TaikiYamada4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your revision!
Could you just fix this part below?

@@ -32,7 +32,7 @@ ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator
You can use `autoware_lanelet2_map_validator` with the following command. This will run all validators including the default built-in validators in the [lanelet2_validation](https://github.com/fzi-forschungszentrum-informatik/Lanelet2/tree/master/lanelet2_validation).

```bash
ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator --map_file path/to_your/lanelet2_map.osm --projection mgrs
ros2 run autoware_lanelet2_map_validator autoware_lanelet2_map_validator --map_file <absolute_or_relative_path_to_autoware_requirement_set.json> --projector mgrs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part should be absolute_or_relative_path_to_lanelet2_map.osm. (or <absolute_or_relative_path/to_your/lanelet2_map.osm> to make it even to other examples)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 2ebb093

Signed-off-by: Mamoru Sobue <[email protected]>
@soblin soblin merged commit 6492e0f into main Jan 8, 2025
27 of 28 checks passed
@soblin soblin deleted the docs/lanelet2-validator branch January 8, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants