Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parameter_estimator)!: replace tier4_debug_msgs with tier4_internal_debug_msgs #198

Conversation

mitsudome-r
Copy link
Member

@mitsudome-r mitsudome-r commented Jan 23, 2025

Description

This replaces tier4_debug_msgs with tier4_internal_debug_msgs.
This is a PR to resolve autowarefoundation/autoware#5580.

Interface Change

Topic Type Topic Name Old Message Type New Message Type
Pub ~/debug_values/* tier4_debug_msgs/Float32MultiArrayStamped autoware_internal_debug_msgs/Float32MultiArrayStamped

How was this PR tested?

I have confirmed that the node can be launched with the following command and confirmed that topics are published with the updated message type

ros2 launch parameter_estimator parameter_estimator.launch.xml vehicle_model:=sample_vehicle

image

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jan 23, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@taikitanaka3 taikitanaka3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 9c0fcc1 into autowarefoundation:main Jan 23, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting XXXStamped messages from tier4_autoware_msgs to autoware_internal_msgs
3 participants