Use local machine to join as validator on any L1 #2548

sukantoraymond · 2025-01-10T07:27:09Z

This PR enables using local machine to join any L1 (Proof of Stake) as a validator.

To join an L1 as validator, call avalanche node local start <clusterName> followed by avalanche node local validate <clusterName>. User will be prompted for RPC URL.

If has more than 1 node in it, all nodes will be added as validators of the specified L1

E2E test will be implemented once #2528 is resolved

cmd/nodecmd/local.go

meaghanfitzgerald · 2025-01-10T16:58:14Z

Can you elaborate in the PR description how a user would accomplish this with the CLI? Is there a new command to import a new L1 configuration or add an active RPC endpoint as a known L1 network? How does this work exactly

sukantoraymond · 2025-01-14T11:04:15Z

cmd/blockchaincmd/deploy.go

@@ -1563,60 +1519,6 @@ func ConvertURIToPeers(uris []string) ([]info.Peer, error) {
 	return aggregatorPeers, nil
 }

-func GetAggregatorExtraPeers(


Moving these functions to blockchain pkg so that it can be re used across cmds

sukantoraymond · 2025-01-14T11:04:36Z

cmd/blockchaincmd/prompt_owners.go

@@ -289,46 +289,3 @@ func getThreshold(maxLen int) (uint32, error) {
 	}
 	return uint32(intTh), err
 }
-
-func getKeyForChangeOwner(network models.Network) (string, error) {


Moving these functions to blockchain pkg so that it can be re used across cmds

sukantoraymond · 2025-01-14T11:06:06Z

pkg/validatormanager/registration.go

@@ -390,7 +390,7 @@ func InitValidatorRegistration(
 		ux.Logger.PrintLineSeparator()
 		ux.Logger.PrintToUser("Initializing a validator registration with PoS validator manager")
 		ux.Logger.PrintToUser("Using rpcURL: %s", rpcURL)
-		ux.Logger.PrintToUser("NodeID: %s staking %s for %ds", nodeID.String(), stakeAmount, uint64(stakeDuration.Seconds()))
+		ux.Logger.PrintToUser("NodeID: %s staking %s", nodeID.String(), stakeAmount)


We don't print duration for L1 validation

isn't this part of PoS staking?

sukantoraymond · 2025-01-14T12:17:23Z

cmd/nodecmd/local.go

+		aggregatorLogger,
+		true,
+		delegationFee,
+		genesis.FujiParams.MinStakeDuration,


Duration is not needed for POS staking, choosing to use genesis.FujiParams.MinStakeDuration as a placeholder duration

felipemadero · 2025-01-14T15:49:48Z

pkg/blockchain/helper.go

+	return peers, nil
+}
+
+func GetBLSInfo(publicKey, proofOfPossesion string) (signer.ProofOfPossession, error) {


change the name to something like ToProofOfProssession

felipemadero · 2025-01-14T15:54:36Z

pkg/validatormanager/registration.go

@@ -444,9 +444,11 @@ func InitValidatorRegistration(
 			ux.Logger.PrintToUser("Error getting validator weight")
 			return nil, ids.Empty, err
 		}
+	} else {
+		// Print validator weight for POA only
+		ux.Logger.PrintToUser(fmt.Sprintf("Validator weight: %d", weight))


can we check if PChain weight is also important for PoS? It seems so IMO

felipemadero · 2025-01-14T20:37:29Z

pkg/validatormanager/registration.go

@@ -390,7 +390,7 @@ func InitValidatorRegistration(
 		ux.Logger.PrintLineSeparator()
 		ux.Logger.PrintToUser("Initializing a validator registration with PoS validator manager")
 		ux.Logger.PrintToUser("Using rpcURL: %s", rpcURL)
-		ux.Logger.PrintToUser("NodeID: %s staking %s for %ds", nodeID.String(), stakeAmount, uint64(stakeDuration.Seconds()))
+		ux.Logger.PrintToUser("NodeID: %s staking %s", nodeID.String(), stakeAmount)


isn't this part of PoS staking?

felipemadero · 2025-01-14T21:08:45Z

cmd/nodecmd/local.go

+func newLocalValidateCmd() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:   "validate [clusterName]",
+		Short: "Validate a specified L1 with an Avalanche Node set up on local machine (PoS only)",


I don't believe it is PoS only. Indeed current impl seems to be PoA only

for POA only validatormanager privatekey owner can add validator. For local machine, if it wants to join an L1, the l1 has to be POS.

felipemadero · 2025-01-14T21:09:15Z

cmd/nodecmd/local.go

+		Long: `Use Avalanche Node set up on local machine to set up specified L1 by providing the
+RPC URL of the L1. 
+
+This command can only be used to validate Proof of Stake L1.`,


Does not serve for PoA?

felipemadero · 2025-01-14T21:14:31Z

cmd/nodecmd/local.go

+			return err
+		}
+	}
+	_, blockchainID, err := utils.SplitAvalanchegoRPCURI(rpcURL)


this assumes too much on the rpc url.... better to either get blockchain ID from chain spec query contract.GetBlockchainID,
and, if not found, prompt the user

RPC url will always have blockchain id in it?

felipemadero · 2025-01-14T21:15:44Z

cmd/nodecmd/local.go

+	cmd.Flags().StringVar(&blockchainName, "blockchain", "", "specify the blockchain the node is syncing with")
+	cmd.Flags().Uint64Var(&stakeAmount, "stake-amount", 0, "(PoS only) amount of tokens to stake")
+	cmd.Flags().StringVar(&rpcURL, "rpc", "", "connect to validator manager at the given rpc endpoint")
+	cmd.Flags().Uint64Var(&balance, "balance", 0, "set the AVAX balance of the validator that will be used for continuous fee on P-Chain")


can you use float balance as in other commands?

felipemadero · 2025-01-14T21:16:14Z

cmd/nodecmd/local.go

+			return err
+		}
+	} else {
+		// convert to nanoAVAX


this has changed, please check latest main on how to best do this for float avax balance

felipemadero · 2025-01-14T21:16:59Z

cmd/nodecmd/local.go

+		balance *= units.Avax
+	}
+
+	if remainingBalanceOwnerAddr == "" {


need flag for this

felipemadero · 2025-01-14T21:17:07Z

cmd/nodecmd/local.go

+		Addresses: remainingBalanceOwnerAddrID,
+	}
+
+	if disableOwnerAddr == "" {


need flag for this

Signed-off-by: sukantoraymond <[email protected]>

use local machine to join as validator

98be86e

sukantoraymond requested a review from a team as a code owner January 10, 2025 07:27

sukantoraymond requested review from arturrez and meaghanfitzgerald January 10, 2025 07:27

sukantoraymond marked this pull request as draft January 10, 2025 07:27

Merge branch 'main' into local-add-validator

d57eb99

github-advanced-security bot found potential problems Jan 10, 2025

View reviewed changes

cmd/nodecmd/local.go Dismissed Show dismissed Hide dismissed

fix lint

8076e6a

meaghanfitzgerald added this to the L1 Validator Management milestone Jan 10, 2025

meaghanfitzgerald assigned sukantoraymond Jan 10, 2025

meaghanfitzgerald mentioned this pull request Jan 10, 2025

Support adding validators to remote L1s (Fuji) #2378

Open

update validate function

830b1d2

sukantoraymond force-pushed the local-add-validator branch from ec0a639 to 830b1d2 Compare January 13, 2025 10:56

Merge branch 'main' into local-add-validator

e310ba7

sukantoraymond linked an issue Jan 13, 2025 that may be closed by this pull request

Support adding validators to remote L1s (Fuji) #2378

Open

sukantoraymond added 3 commits January 14, 2025 17:56

local machine validate l1

d6793bf

update command description

4177a8e

Merge branch 'main' into local-add-validator

07e8310

sukantoraymond marked this pull request as ready for review January 14, 2025 11:03

sukantoraymond commented Jan 14, 2025

View reviewed changes

lint

04f5e35

sukantoraymond commented Jan 14, 2025

View reviewed changes

lint

ba9ad16

sukantoraymond commented Jan 14, 2025

View reviewed changes

felipemadero reviewed Jan 14, 2025

View reviewed changes

sukantoraymond added 3 commits January 15, 2025 17:17

address comments

e0bbeec

Merge branch 'main' into local-add-validator

6976cdc

Signed-off-by: sukantoraymond <[email protected]>

fix merge

c43b351

sukantoraymond added 2 commits January 15, 2025 17:38

address comments

b61952a

enable more than 1 node in a cluster to validate

a7114e1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use local machine to join as validator on any L1 #2548

Use local machine to join as validator on any L1 #2548

sukantoraymond commented Jan 10, 2025 •

edited

Loading

meaghanfitzgerald commented Jan 10, 2025

sukantoraymond Jan 14, 2025

sukantoraymond Jan 14, 2025

sukantoraymond Jan 14, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 14, 2025 •

edited

Loading

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

felipemadero Jan 14, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

felipemadero Jan 14, 2025

sukantoraymond Jan 15, 2025

Use local machine to join as validator on any L1 #2548

Are you sure you want to change the base?

Use local machine to join as validator on any L1 #2548

Conversation

sukantoraymond commented Jan 10, 2025 • edited Loading

meaghanfitzgerald commented Jan 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sukantoraymond Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sukantoraymond commented Jan 10, 2025 •

edited

Loading

sukantoraymond Jan 14, 2025 •

edited

Loading