Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA: fix flaky tests #1446

Merged
merged 1 commit into from
Jul 31, 2024
Merged

QA: fix flaky tests #1446

merged 1 commit into from
Jul 31, 2024

Conversation

eunjisong
Copy link
Contributor

Description

fix tests below for both iOS and Android

  • Should add BTC network to favorites
  • Create new wallet

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@eunjisong eunjisong marked this pull request as ready for review July 30, 2024 21:04
Any2suited66
Any2suited66 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@Any2suited66 Any2suited66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eunjisong eunjisong merged commit 44b0dff into main Jul 31, 2024
3 checks passed
@eunjisong eunjisong deleted the qa-fix-flaky branch July 31, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Any2suited66 Any2suited66 Any2suited66 approved these changes

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@atn4z7 atn4z7 Awaiting requested review from atn4z7 atn4z7 is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

@onghwan onghwan Awaiting requested review from onghwan onghwan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @Any2suited66