CP-9664: Add Support for New Notification Types #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruijialin-avalabs
requested review from
neven-s,
atn4z7 and
onghwan
as code owners
atn4z7
reviewed
Jan 8, 2025
atn4z7
reviewed
Jan 8, 2025
| } | ||
| global.fetch = jest.fn(() => Promise.resolve(mockResponse)) as jest.Mock | ||
|
|
||
| await expect( |
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/services/notifications/news/subscribeForNews.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/services/notifications/news/subscribeForNews.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/services/notifications/news/unsubscribeForNews.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/services/notifications/news/unsubscribeForNews.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/store/notifications/listeners/listeners.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/store/notifications/listeners/listeners.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/store/notifications/listeners/listeners.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/store/notifications/listeners/listeners.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/store/notifications/listeners/unsubscribeAllNotifications.ts
Outdated
Show resolved
Hide resolved
atn4z7
reviewed
Jan 8, 2025
packages/core-mobile/app/store/notifications/listeners/subscribeNewsNotifications.ts
Outdated
Show resolved
Hide resolved
atn4z7
previously approved these changes
Jan 8, 2025
atn4z7
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9664
all-notifications) to control all in-app notificationsbalance-change-notificationsff logic since all notifications is controlled withall-notificationsffScreenshots/Videos
videos in Jira comment: https://ava-labs.atlassian.net/browse/CP-9664?focusedCommentId=44642
Checklist
Please check all that apply (if applicable)