Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9664: Add missing news events to channel Id mapping #2183

Merged
merged 3 commits into from
Jan 9, 2025

Conversation

ruijialin-avalabs
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs commented Jan 8, 2025

Description

Ticket: CP-9664

  • News events to channel id mapping was missing, so the android news notification was not delivered.
  • use default sound for new notifications

Screenshots/Videos

  • android notification
Screen.Recording.2025-01-08.at.4.15.00.PM.mov
  • default sound for ios notification
Screen.Recording.2025-01-08.at.4.15.54.PM.mov

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@ruijialin-avalabs ruijialin-avalabs marked this pull request as ready for review January 8, 2025 21:17
atn4z7
atn4z7 previously approved these changes Jan 8, 2025
@ruijialin-avalabs ruijialin-avalabs merged commit d163a38 into main Jan 9, 2025
4 checks passed
@ruijialin-avalabs ruijialin-avalabs deleted the cp-9664-2 branch January 9, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants