Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use typeguard for action matchers #2184

Merged
merged 1 commit into from
Jan 9, 2025
Merged

use typeguard for action matchers #2184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 50 additions & 34 deletions packages/core-mobile/app/store/notifications/listeners/listeners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,68 +192,84 @@ export const addNotificationsListeners = (
}

const onNotificationsTurnedOnForBalanceChange = {
match: (action: Action<unknown>): action is PayloadAction => {
return (
action.type === turnOnNotificationsFor.type &&
(action as PayloadAction<{ channelId: ChannelId }>).payload.channelId ===
ChannelId.BALANCE_CHANGES
)
match: (
action: Action<unknown>
): action is PayloadAction<{ channelId: ChannelId }> => {
if (!turnOnNotificationsFor.match(action)) {
return false
}

return action.payload.channelId === ChannelId.BALANCE_CHANGES
}
}

const onNotificationsTurnedOnForNews = {
match: (action: Action<unknown>): action is PayloadAction => {
const channelId = (action as PayloadAction<{ channelId: ChannelId }>)
.payload.channelId
match: (
action: Action<unknown>
): action is PayloadAction<{ channelId: ChannelId }> => {
if (!turnOnNotificationsFor.match(action)) {
return false
}

const channelId = action.payload.channelId

return (
action.type === turnOnNotificationsFor.type &&
(channelId === ChannelId.MARKET_NEWS ||
channelId === ChannelId.OFFERS_AND_PROMOTIONS ||
channelId === ChannelId.PRODUCT_ANNOUNCEMENTS ||
channelId === ChannelId.PRICE_ALERTS)
channelId === ChannelId.MARKET_NEWS ||
channelId === ChannelId.OFFERS_AND_PROMOTIONS ||
channelId === ChannelId.PRODUCT_ANNOUNCEMENTS ||
channelId === ChannelId.PRICE_ALERTS
)
}
}

const onNotificationsTurnedOffForBalanceChange = {
match: (action: Action<unknown>): action is PayloadAction => {
return (
action.type === turnOffNotificationsFor.type &&
(action as PayloadAction<{ channelId: ChannelId }>).payload.channelId ===
ChannelId.BALANCE_CHANGES
)
match: (
action: Action<unknown>
): action is PayloadAction<{ channelId: ChannelId }> => {
if (!turnOffNotificationsFor.match(action)) {
return false
}

return action.payload.channelId === ChannelId.BALANCE_CHANGES
}
}

const onNotificationsTurnedOffForNews = {
match: (action: Action<unknown>): action is PayloadAction => {
const channelId = (action as PayloadAction<{ channelId: ChannelId }>)
.payload.channelId
match: (
action: Action<unknown>
): action is PayloadAction<{ channelId: ChannelId }> => {
if (!turnOffNotificationsFor.match(action)) {
return false
}

const channelId = action.payload.channelId

return (
action.type === turnOffNotificationsFor.type &&
(channelId === ChannelId.MARKET_NEWS ||
channelId === ChannelId.OFFERS_AND_PROMOTIONS ||
channelId === ChannelId.PRODUCT_ANNOUNCEMENTS ||
channelId === ChannelId.PRICE_ALERTS)
channelId === ChannelId.MARKET_NEWS ||
channelId === ChannelId.OFFERS_AND_PROMOTIONS ||
channelId === ChannelId.PRODUCT_ANNOUNCEMENTS ||
channelId === ChannelId.PRICE_ALERTS
)
}
}

const onNotificationsEnabled = {
match: (action: Action<unknown>): action is PayloadAction => {
if (action.type === setFeatureFlags.type) {
const setFeatureFlagsAction = action as PayloadAction<FeatureFlags>
match: (action: Action<unknown>): action is PayloadAction<FeatureFlags> => {
if (setFeatureFlags.match(action)) {
const setFeatureFlagsAction = action
return !!setFeatureFlagsAction.payload[FeatureGates.ALL_NOTIFICATIONS]
}

return false
}
}
const onNotificationsDisabled = {
match: (action: Action<unknown>): action is PayloadAction => {
if (action.type === setFeatureFlags.type) {
const setFeatureFlagsAction = action as PayloadAction<FeatureFlags>
match: (action: Action<unknown>): action is PayloadAction<FeatureFlags> => {
if (setFeatureFlags.match(action)) {
const setFeatureFlagsAction = action
return !setFeatureFlagsAction.payload[FeatureGates.ALL_NOTIFICATIONS]
}

return false
}
}
Loading