-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move AST to separate package #180
base: master
Are you sure you want to change the base?
Conversation
The original request for this was from quite a while ago so I wanted to check if we still need to split this out into a separate package? I do think there is a good reason to split into multiple packages, but for a different reason: I think there should be a package that implements the code generation logic and the generated code should depend on a separate package. However, I don't believe separating out the AST into a separate package addresses that. |
I can't think of a reason why the syntax datatype would be useful in a separate package even if I went ahead and added the parser into the new package. I don't mind removing the new package, but I do think that some of the changes in this PR like documentation, removing orphan instances out of |
…uite into jake/separate-ast
This PR isolates
Proto3.Suite.DotProto.AST
into separate packageproto3-suite-ast
.