Deprecate awesome.load_image
#3976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: delta <[email protected]>
actionless
approved these changes
Nov 28, 2024
sclu1034
reviewed
Nov 28, 2024
| * awesome.pixbuf_to_surface | ||
| */ | ||
|
|
||
| luaA_deprecate(L, "awesome.pixbuf_to_surface"); |
There was a problem hiding this comment.
The suggestion for awesome.pixbuf_to_surface in that comment has since become outdated as well. I think gears.surface would be a better suggestion.
There was a problem hiding this comment.
gears.surface uses awesome.pixbuf_to_surface internally, and I would argue that it's better to put a function as close to the replaced one in functionality in @deprecate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it currently stands, both
luaA_load_imageanddraw_load_imageare left unused and only serve to padluaa.canddraw.crespectively. This PR deprecates the former to allow the eventual removal of both.