Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package json name and deps, always set generateSecrets prop #14070

Open
wants to merge 3 commits into
base: migrations
Choose a base branch
from

Conversation

abhi7cr
Copy link
Contributor

@abhi7cr abhi7cr commented Jan 15, 2025

Description of changes

QA bug fixes:

  • Do not replace package.json dependencies and devDependencies. Only override ones that are needed.
  • Pin dependencies to match the versions set in create-amplify npx command
  • Set generateSecret: false when ClientSecret is not defined. This will prevent creation of a new user pool client post refactor
  • Preserve package.json name
  • Change logical id of user pool client to indicate its a Native one

Description of how you validated changes

Manual testing, unit tests

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abhi7cr abhi7cr requested a review from a team as a code owner January 15, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant