Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure generated code matches expected output #118

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

jhosteny
Copy link
Contributor

This removes a newline from the generated code, so that it matches the expected output.

This removes a newline from the generated code, so that it matches the
expected output.
@jhosteny
Copy link
Contributor Author

Hi @onno-vos-dev , while working on a test for #117, I discovered the current tests / codegen had a slight discrepancy. I elected to modify the codegen to put this on one line, rather than modify the expectation. I will rebase #117 onto this once it is merged. Thanks!

@onno-vos-dev
Copy link
Member

Hi @onno-vos-dev , while working on a test for #117, I discovered the current tests / codegen had a slight discrepancy. I elected to modify the codegen to put this on one line, rather than modify the expectation. I will rebase #117 onto this once it is merged. Thanks!

Sounds good! Thank you! 🙇

@onno-vos-dev onno-vos-dev merged commit 879a665 into aws-beam:master Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants