Update to ACK runtime v0.39.0, code-generator v0.39.1 (#25)

### Update to ACK runtime `v0.39.0`, code-generator `v0.39.1` ---------- * ACK code-generator `v0.39.1` [release notes](https://github.com/aws-controllers-k8s/code-generator/releases/tag/v0.39.1) * ACK runtime `v0.39.0` [release notes](https://github.com/aws-controllers-k8s/runtime/releases/tag/v0.39.0) ---------- NOTE: This PR increments the release version of service controller from `v0.0.10` to `v0.0.11` Once this PR is merged, release `v0.0.11` will be automatically created for `route53resolver-controller` **Please close this PR, if you do not want the new patch release for `route53resolver-controller`** ---------- #### stdout for `make build-controller`: ``` building ack-generate ... ok. ==== building route53resolver-controller ==== Copying common custom resource definitions into route53resolver Building Kubernetes API objects for route53resolver Generating deepcopy code for route53resolver Generating custom resource definitions for route53resolver Building service controller for route53resolver Generating RBAC manifests for route53resolver Running gofmt against generated code for route53resolver Updating additional GitHub repository maintenance files ==== building route53resolver-controller release artifacts ==== Building release artifacts for route53resolver-v0.0.11 Generating common custom resource definitions Generating custom resource definitions for route53resolver Generating RBAC manifests for route53resolver ``` ---------- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
aws-controllers-k8s · Oct 12, 2024 · b6ac634 · b6ac634
1 parent 8bbc057
commit b6ac634
Show file tree

Hide file tree

Showing 18 changed files with 129 additions and 289 deletions.
diff --git a/apis/v1alpha1/ack-generate-metadata.yaml b/apis/v1alpha1/ack-generate-metadata.yaml
@@ -1,8 +1,8 @@
 ack_generate_info:
-  build_date: "2024-08-29T17:14:39Z"
-  build_hash: f8f98563404066ac3340db0a049d2e530e5c51cc
-  go_version: go1.22.5
-  version: v0.38.1
+  build_date: "2024-10-10T04:04:43Z"
+  build_hash: 36c2d234498c2bc4f60773ab8df632af4067f43b
+  go_version: go1.23.2
+  version: v0.39.1
 api_directory_checksum: 9a42343e86bd2d87a33f81b6a69245d083eac571
 api_version: v1alpha1
 aws_sdk_go_version: v1.44.300

diff --git a/config/controller/kustomization.yaml b/config/controller/kustomization.yaml
@@ -6,4 +6,4 @@ kind: Kustomization
 images:
 - name: controller
   newName: public.ecr.aws/aws-controllers-k8s/route53resolver-controller
-  newTag: 0.0.10
+  newTag: 0.0.11
diff --git a/config/crd/bases/route53resolver.services.k8s.aws_resolverendpoints.yaml b/config/crd/bases/route53resolver.services.k8s.aws_resolverendpoints.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: resolverendpoints.route53resolver.services.k8s.aws
 spec:
   group: route53resolver.services.k8s.aws
@@ -44,7 +44,6 @@ spec:
             description: |-
               ResolverEndpointSpec defines the desired state of ResolverEndpoint.
 
-
               In the response to a CreateResolverEndpoint (https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53resolver_CreateResolverEndpoint.html),
               DeleteResolverEndpoint (https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53resolver_DeleteResolverEndpoint.html),
               GetResolverEndpoint (https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53resolver_GetResolverEndpoint.html),
@@ -57,11 +56,9 @@ spec:
                 description: |-
                   Specify the applicable value:
 
-
                      * INBOUND: Resolver forwards DNS queries to the DNS service for a VPC
                      from your network
 
-
                      * OUTBOUND: Resolver forwards DNS queries from the DNS service for a VPC
                      to your network
                 type: string
@@ -125,7 +122,7 @@ spec:
                 items:
                   description: "AWSResourceReferenceWrapper provides a wrapper around
                     *AWSResourceReference\ntype to provide more user friendly syntax
-                    for references using 'from' field\nEx:\nAPIIDRef:\n\n\n\tfrom:\n\t
+                    for references using 'from' field\nEx:\nAPIIDRef:\n\n\tfrom:\n\t
                     \ name: my-api"
                   properties:
                     from:
@@ -175,7 +172,6 @@ spec:
                       when it has verified that an "adopted" resource (a resource where the
                       ARN annotation was set by the Kubernetes user on the CR) exists and
                       matches the supplied CR's Spec field values.
-                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
                       https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID:
@@ -259,27 +255,22 @@ spec:
                   A code that specifies the current status of the Resolver endpoint. Valid
                   values include the following:
 
-
                      * CREATING: Resolver is creating and configuring one or more Amazon VPC
                      network interfaces for this endpoint.
 
-
                      * OPERATIONAL: The Amazon VPC network interfaces for this endpoint are
                      correctly configured and able to pass inbound or outbound DNS queries
                      between your network and Resolver.
 
-
                      * UPDATING: Resolver is associating or disassociating one or more network
                      interfaces with this endpoint.
 
-
                      * AUTO_RECOVERING: Resolver is trying to recover one or more of the network
                      interfaces that are associated with this endpoint. During the recovery
                      process, the endpoint functions with limited capacity because of the limit
                      on the number of DNS queries per IP address (per network interface). For
                      the current limit, see Limits on Route 53 Resolver (https://docs.aws.amazon.com/Route53/latest/DeveloperGuide/DNSLimitations.html#limits-api-entities-resolver).
 
-
                      * ACTION_NEEDED: This endpoint is unhealthy, and Resolver can't automatically
                      recover it. To resolve the problem, we recommend that you check each IP
                      address that you associated with the endpoint. For each IP address that
@@ -291,7 +282,6 @@ spec:
                      interface couldn't be created for some reason that's outside the control
                      of Resolver.
 
-
                      * DELETING: Resolver is deleting this endpoint and the associated network
                      interfaces.
                 type: string

diff --git a/config/crd/bases/route53resolver.services.k8s.aws_resolverrules.yaml b/config/crd/bases/route53resolver.services.k8s.aws_resolverrules.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: resolverrules.route53resolver.services.k8s.aws
 spec:
   group: route53resolver.services.k8s.aws
@@ -44,7 +44,6 @@ spec:
             description: |-
               ResolverRuleSpec defines the desired state of ResolverRule.
 
-
               For queries that originate in your VPC, detailed information about a Resolver
               rule, which specifies how to route DNS queries out of the VPC. The ResolverRule
               parameter appears in the response to a CreateResolverRule (https://docs.aws.amazon.com/Route53/latest/APIReference/API_route53resolver_CreateResolverRule.html),
@@ -100,18 +99,15 @@ spec:
                   When you want to forward DNS queries for specified domain name to resolvers
                   on your network, specify FORWARD.
 
-
                   When you have a forwarding rule to forward DNS queries for a domain to your
                   network and you want Resolver to process queries for a subdomain of that
                   domain, specify SYSTEM.
 
-
                   For example, to forward DNS queries for example.com to resolvers on your
                   network, you create a rule and specify FORWARD for RuleType. To then have
                   Resolver process queries for apex.example.com, you create a rule and specify
                   SYSTEM for RuleType.
 
-
                   Currently, only Resolver can create rules that have a value of RECURSIVE
                   for RuleType.
                 type: string
@@ -134,7 +130,6 @@ spec:
                   The IPs that you want Resolver to forward DNS queries to. You can specify
                   only IPv4 addresses. Separate IP addresses with a space.
 
-
                   TargetIps is available only when the value of Rule type is FORWARD.
                 items:
                   description: |-
@@ -171,7 +166,6 @@ spec:
                       when it has verified that an "adopted" resource (a resource where the
                       ARN annotation was set by the Kubernetes user on the CR) exists and
                       matches the supplied CR's Spec field values.
-                      TODO(vijat@): Find a better strategy for resources that do not have ARN in CreateOutputResponse
                       https://github.com/aws/aws-controllers-k8s/issues/270
                     type: string
                   ownerAccountID:

diff --git a/config/crd/common/bases/services.k8s.aws_adoptedresources.yaml b/config/crd/common/bases/services.k8s.aws_adoptedresources.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: adoptedresources.services.k8s.aws
 spec:
   group: services.k8s.aws
@@ -78,11 +78,9 @@ spec:
                       automatically converts this to an arbitrary string-string map.
                       https://github.com/kubernetes-sigs/controller-tools/issues/385
 
-
                       Active discussion about inclusion of this field in the spec is happening in this PR:
                       https://github.com/kubernetes-sigs/controller-tools/pull/395
 
-
                       Until this is allowed, or if it never is, we will produce a subset of the object meta
                       that contains only the fields which the user is allowed to modify in the metadata.
                     properties:
@@ -105,13 +103,11 @@ spec:
                           and may be truncated by the length of the suffix required to make the value
                           unique on the server.
 
-
                           If this field is specified and the generated name exists, the server will
                           NOT return a 409 - instead, it will either return 201 Created or 500 with Reason
                           ServerTimeout indicating a unique name could not be found in the time allotted, and the client
                           should retry (optionally after the time indicated in the Retry-After header).
 
-
                           Applied only if Name is not specified.
                           More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#idempotency
                         type: string
@@ -140,7 +136,6 @@ spec:
                           Not all objects are required to be scoped to a namespace - the value of this field for
                           those objects will be empty.
 
-
                           Must be a DNS_LABEL.
                           Cannot be updated.
                           More info: http://kubernetes.io/docs/user-guide/namespaces

diff --git a/config/crd/common/bases/services.k8s.aws_fieldexports.yaml b/config/crd/common/bases/services.k8s.aws_fieldexports.yaml
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.14.0
+    controller-gen.kubebuilder.io/version: v0.16.2
   name: fieldexports.services.k8s.aws
 spec:
   group: services.k8s.aws

diff --git a/config/rbac/cluster-role-controller.yaml b/config/rbac/cluster-role-controller.yaml
@@ -8,6 +8,7 @@ rules:
   - ""
   resources:
   - configmaps
+  - secrets
   verbs:
   - get
   - list
@@ -21,39 +22,12 @@ rules:
   - get
   - list
   - watch
-- apiGroups:
-  - ""
-  resources:
-  - secrets
-  verbs:
-  - get
-  - list
-  - patch
-  - watch
 - apiGroups:
   - ec2.services.k8s.aws
   resources:
   - securitygroups
-  verbs:
-  - get
-  - list
-- apiGroups:
-  - ec2.services.k8s.aws
-  resources:
   - securitygroups/status
-  verbs:
-  - get
-  - list
-- apiGroups:
-  - ec2.services.k8s.aws
-  resources:
   - subnets
-  verbs:
-  - get
-  - list
-- apiGroups:
-  - ec2.services.k8s.aws
-  resources:
   - subnets/status
   verbs:
   - get
@@ -62,25 +36,6 @@ rules:
   - route53resolver.services.k8s.aws
   resources:
   - resolverendpoints
-  verbs:
-  - create
-  - delete
-  - get
-  - list
-  - patch
-  - update
-  - watch
-- apiGroups:
-  - route53resolver.services.k8s.aws
-  resources:
-  - resolverendpoints/status
-  verbs:
-  - get
-  - patch
-  - update
-- apiGroups:
-  - route53resolver.services.k8s.aws
-  resources:
   - resolverrules
   verbs:
   - create
@@ -93,6 +48,7 @@ rules:
 - apiGroups:
   - route53resolver.services.k8s.aws
   resources:
+  - resolverendpoints/status
   - resolverrules/status
   verbs:
   - get
@@ -102,25 +58,6 @@ rules:
   - services.k8s.aws
   resources:
   - adoptedresources
-  verbs:
-  - create
-  - delete
-  - get
-  - list
-  - patch
-  - update
-  - watch
-- apiGroups:
-  - services.k8s.aws
-  resources:
-  - adoptedresources/status
-  verbs:
-  - get
-  - patch
-  - update
-- apiGroups:
-  - services.k8s.aws
-  resources:
   - fieldexports
   verbs:
   - create
@@ -133,6 +70,7 @@ rules:
 - apiGroups:
   - services.k8s.aws
   resources:
+  - adoptedresources/status
   - fieldexports/status
   verbs:
   - get