Add ability to customize fluent bit config via values.yaml #43
Conversation
| Regex (?<log>(?<="log":")\d{4}[\/-]\d{1,2}[\/-]\d{1,2}[ T]\d{2}:\d{2}:\d{2}(?!\.).*?)(?<!\\)".*(?<stream>(?<="stream":").*?)".*(?<time>\d{4}-\d{1,2}-\d{1,2}T\d{2}:\d{2}:\d{2}\.\w*).*(?=}) | ||
| Time_Key time | ||
| Time_Format %Y-%m-%dT%H:%M:%S.%LZ | ||
| {{- .Values.containerLogs.fluentBit.config.customParsers | nindent 4 }} |
There was a problem hiding this comment.
is there a reason we split up the parsers and the fluentbit conf specifically? Seems like there's a lot of in-between configs too such as application-log, host-log, etc.
There was a problem hiding this comment.
I tried to keep it close to the actual fluent-bit helm chart so that it looks familiar for users already using that.
https://github.com/fluent/helm-charts/blob/main/charts/fluent-bit/values.yaml#L367
Hence Ive exposed the service, customParsers and extraFiles as top level attributes. The application-log, host-log etc are specific to the way we have prescribed these files in our public docs in the past. We typically dont have root level inputs, filters and outputs in the main fluent-bit.conf and always take them in as additional/extra files.
Description of changes: Moving the fluent bit config to values.yaml to allow users to easily override it via helm and the Amazon CloudWatch Observability EKS add-on.
Testing: This change is essentially a no-op in terms of the rendered manifests. Confirmed the same by rendering the chart with & without my changes to ensure the content is the same.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.