Bump deps and misc small code improvements #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For anybody (like me) who prefers to install aws-cdk NPM library locally instead of globally.
Bump CDK library and LangChain/LangFuse/etc example notebook dependencies to newer tested versions. Update SMStudio kernel spec note in example notebook. Consolidate pip install statements to improve dependency resolution.
Add explicit type annotations on params of CDK stacks to improve auto-complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Just some minor version bumps and small code tweaks to help keep the sample up-to-date and readable:
aws-cdk-libto latest andcdk-ecr-deploymentto most recent working version not affected by the bug mentioned herepip installcommands in the notebook to one, for more reliable dependency resolution; and prefer%pipmagic (which should always resolve to the package manager within the current notebook kernel) rather than!pip(which, in rare/weird environments, can possibly refer to something else)node_modulesfor the benefit of anybody (like me) who prefers to install their AWS CDK CLI locally per-project rather than globally - in case of version mismatchesStackobjects, so IDE auto-complete works within these files.Testing done:
Deployed the stacks with updated CDK version and code in a new environment; opened the example notebook in a SageMaker AI Studio JupyterLab space (SM Distribution v2.2.1); ran through and verified tracing worked and was visible in the Langfuse environment.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.